Fix under-repaint in non-RAL mode

Fix under-repaint in non-RAL mode

The under-repaint occurs in non-RAL mode when an object needs both
repaint and non-full layout. https://codereview.chromium.org/265703012/
caused this because it skips the direct repaint() call in the above
case.

BUG=376306
TEST=fast/repaint/change-text-content-and-background-color.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174989

[Xianzhu, 2014-05-23 20:14:27]

PTAL

[Xianzhu, 2014-05-27 18:59:31]

Ping...

It seems hard to keep non-RAL right because we are testing in RAL mode. Even I
disable RAL mode locally, there are still no non-RAL mode layout test baselines.

Will we enable RAL mode soon?

[Julien - ping for review, 2014-05-28 06:08:03]

lgtm

> It seems hard to keep non-RAL right because we are testing in RAL mode. Even I
> disable RAL mode locally, there are still no non-RAL mode layout test
baselines.
> 
> Will we enable RAL mode soon?

We are blocked on several nasty regressions to enable RAL for releases but we
would like to do it once these are cleared.

[esprehn, 2014-05-28 08:55:42]

On 2014/05/28 06:08:03, Julien Chaffraix - CET wrote:
> lgtm
> 
> > It seems hard to keep non-RAL right because we are testing in RAL mode. Even
I
> > disable RAL mode locally, there are still no non-RAL mode layout test
> baselines.
> > 
> > Will we enable RAL mode soon?
> 
> We are blocked on several nasty regressions to enable RAL for releases but we
> would like to do it once these are cleared.

We should disable it for tests then. Right now we're getting no test coverage
for the repaint path we're shipping to users.

[esprehn, 2014-05-28 08:55:50]

https://codereview.chromium.org/298973011/diff/40001/Source/core/rendering/Re...
File Source/core/rendering/RenderObject.cpp (right):

https://codereview.chromium.org/298973011/diff/40001/Source/core/rendering/Re...
Source/core/rendering/RenderObject.cpp:2074: if
(RuntimeEnabledFeatures::repaintAfterLayoutEnabled && needsLayout())
Missing parens in function call

[Xianzhu, 2014-05-28 16:56:26]

https://codereview.chromium.org/298973011/diff/40001/Source/core/rendering/Re...
File Source/core/rendering/RenderObject.cpp (right):

https://codereview.chromium.org/298973011/diff/40001/Source/core/rendering/Re...
Source/core/rendering/RenderObject.cpp:2074: if
(RuntimeEnabledFeatures::repaintAfterLayoutEnabled && needsLayout())
On 2014/05/28 08:55:51, esprehn wrote:
> Missing parens in function call

Thanks for finding this which voided half of this CL!

Fixed.

[Xianzhu, 2014-05-28 16:56:32]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-05-28 16:57:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/298973011/60001

[Xianzhu, 2014-05-28 18:30:21]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-05-28 18:30:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/298973011/80001

[commit-bot: I haz the power, 2014-05-28 20:31:26]

Change committed as 174989

[Alexander Potapenko, 2014-05-29 13:33:25]

On 2014/05/28 20:31:26, I haz the power (commit-bot) wrote:
> Change committed as 174989
You must have supplied the wrond bug id.