Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1473)

Unified Diff: Source/core/rendering/RenderObject.cpp

Issue 298973011: Fix under-repaint in non-RAL mode (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: NeedsRebaseline on mac Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/repaint/change-text-content-and-background-color-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderObject.cpp
diff --git a/Source/core/rendering/RenderObject.cpp b/Source/core/rendering/RenderObject.cpp
index d6f6ef8d07cb5d2af2a7100f2890331458520219..47ccf7637b67c04b6aa0e45c46a30640622b85af 100644
--- a/Source/core/rendering/RenderObject.cpp
+++ b/Source/core/rendering/RenderObject.cpp
@@ -2071,9 +2071,9 @@ void RenderObject::setStyle(PassRefPtr<RenderStyle> style)
if (updatedDiff.needsRepaint()) {
// Repaint with the new style, e.g., for example if we go from not having
// an outline to having an outline.
- if (needsLayout())
+ if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled() && needsLayout())
setShouldDoFullRepaintAfterLayout(true);
- else
+ else if (!selfNeedsLayout())
repaint();
}
}
@@ -2112,9 +2112,9 @@ void RenderObject::styleWillChange(StyleDifference diff, const RenderStyle& newS
}
if (m_parent && diff.needsRepaintObject()) {
- if (diff.needsLayout() || needsLayout())
+ if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled() && (diff.needsLayout() || needsLayout()))
setShouldDoFullRepaintAfterLayout(true);
- else
+ else if (!diff.needsFullLayout() && !selfNeedsLayout())
repaint();
}
« no previous file with comments | « LayoutTests/fast/repaint/change-text-content-and-background-color-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698