Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Issue 298973004: In convexity checker don't advance last vector when x-product isn't significant. (Closed)

Created:
6 years, 7 months ago by bsalomon
Modified:
6 years, 7 months ago
Reviewers:
caryclark
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

In convexity checker don't advance last vector when x-product isn't significant. BUG=skia:2235 Committed: http://code.google.com/p/skia/source/detail?r=14845

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update #

Patch Set 4 : remove debugging code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -18 lines) Patch
M src/core/SkPath.cpp View 1 2 4 chunks +14 lines, -18 lines 0 comments Download
M tests/PathTest.cpp View 2 3 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
6 years, 7 months ago (2014-05-22 14:40:58 UTC) #1
caryclark
lgtm
6 years, 7 months ago (2014-05-22 14:50:39 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 7 months ago (2014-05-22 14:53:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/298973004/60001
6 years, 7 months ago (2014-05-22 14:53:42 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 14:58:55 UTC) #5
Message was sent while issue was closed.
Change committed as 14845

Powered by Google App Engine
This is Rietveld 408576698