Oilpan: Move ClickHandlingState to heap

Oilpan: Move ClickHandlingState to heap

BUG=357163
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175533

[zerny-chromium, 2014-05-22 10:03:42]

lgtm. It is nice to get rid of the "does this leak" cases :-)

https://codereview.chromium.org/298963003/diff/1/Source/core/html/forms/Input...
File Source/core/html/forms/InputTypeView.h (right):

https://codereview.chromium.org/298963003/diff/1/Source/core/html/forms/Input...
Source/core/html/forms/InputTypeView.h:57: struct ClickHandlingState : public
NoBaseWillBeGarbageCollected<ClickHandlingState> {
Nit: FINAL

[keishi, 2014-05-22 10:37:12]

yup it sure is

https://codereview.chromium.org/298963003/diff/1/Source/core/html/forms/Input...
File Source/core/html/forms/InputTypeView.h (right):

https://codereview.chromium.org/298963003/diff/1/Source/core/html/forms/Input...
Source/core/html/forms/InputTypeView.h:57: struct ClickHandlingState : public
NoBaseWillBeGarbageCollected<ClickHandlingState> {
On 2014/05/22 10:03:43, zerny-chromium wrote:
> Nit: FINAL

Done.

[haraken, 2014-05-22 10:44:50]

LGTM

https://codereview.chromium.org/298963003/diff/10001/Source/core/html/HTMLInp...
File Source/core/html/HTMLInputElement.cpp (right):

https://codereview.chromium.org/298963003/diff/10001/Source/core/html/HTMLInp...
Source/core/html/HTMLInputElement.cpp:1097: return
m_inputTypeView->willDispatchClick().leakPtr();

Shall we add RawPtr::leakPtr so that we don't need the #if branch?

[keishi, 2014-05-30 02:35:31]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2014-05-30 02:36:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/keishi@chromium.org/298963003/10001

[commit-bot: I haz the power, 2014-05-30 02:36:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-30 02:36:24]

Failed to apply patch for Source/core/html/forms/InputTypeView.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/html/forms/InputTypeView.h
  Hunk #1 FAILED at 54.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/html/forms/InputTypeView.h.rej

Patch:       Source/core/html/forms/InputTypeView.h
Index: Source/core/html/forms/InputTypeView.h
diff --git a/Source/core/html/forms/InputTypeView.h
b/Source/core/html/forms/InputTypeView.h
index
73e66997bc3fbd1ab3545891aca07b2b6c0b38d9..808fde90803bbaa0cecdafd53877a60dffa22674
100644
--- a/Source/core/html/forms/InputTypeView.h
+++ b/Source/core/html/forms/InputTypeView.h
@@ -54,13 +54,15 @@ class RenderObject;
 class RenderStyle;
 class TouchEvent;
 
-struct ClickHandlingState {
-    WTF_MAKE_FAST_ALLOCATED;
+struct ClickHandlingState FINAL : public
NoBaseWillBeGarbageCollected<ClickHandlingState> {
+    WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
 
 public:
+    void trace(Visitor*);
+
     bool checked;
     bool indeterminate;
-    RefPtr<HTMLInputElement> checkedRadioButton;
+    RefPtrWillBeMember<HTMLInputElement> checkedRadioButton;
 };
 
 // An InputTypeView object represents the UI-specific part of an
@@ -78,7 +80,7 @@ public:
     virtual bool sizeShouldIncludeDecoration(int defaultSize, int&
preferredSize) const;
     virtual void handleClickEvent(MouseEvent*);
     virtual void handleMouseDownEvent(MouseEvent*);
-    virtual PassOwnPtr<ClickHandlingState> willDispatchClick();
+    virtual PassOwnPtrWillBeRawPtr<ClickHandlingState> willDispatchClick();
     virtual void didDispatchClick(Event*, const ClickHandlingState&);
     virtual void handleKeydownEvent(KeyboardEvent*);
     virtual void handleKeypressEvent(KeyboardEvent*);

[keishi, 2014-06-05 04:05:37]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2014-06-05 04:06:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/keishi@chromium.org/298963003/30001

[commit-bot: I haz the power, 2014-06-05 05:19:09]

Change committed as 175533