Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Unified Diff: Source/core/html/forms/InputTypeView.h

Issue 298963003: Oilpan: Move ClickHandlingState to heap (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/forms/CheckboxInputType.cpp ('k') | Source/core/html/forms/InputTypeView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/forms/InputTypeView.h
diff --git a/Source/core/html/forms/InputTypeView.h b/Source/core/html/forms/InputTypeView.h
index 80d9c501fb0430275ab3daa74476a97ec901feef..808fde90803bbaa0cecdafd53877a60dffa22674 100644
--- a/Source/core/html/forms/InputTypeView.h
+++ b/Source/core/html/forms/InputTypeView.h
@@ -54,13 +54,15 @@ class RenderObject;
class RenderStyle;
class TouchEvent;
-struct ClickHandlingState {
- WTF_MAKE_FAST_ALLOCATED;
+struct ClickHandlingState FINAL : public NoBaseWillBeGarbageCollected<ClickHandlingState> {
+ WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
public:
+ void trace(Visitor*);
+
bool checked;
bool indeterminate;
- RefPtrWillBePersistent<HTMLInputElement> checkedRadioButton;
+ RefPtrWillBeMember<HTMLInputElement> checkedRadioButton;
};
// An InputTypeView object represents the UI-specific part of an
@@ -78,7 +80,7 @@ public:
virtual bool sizeShouldIncludeDecoration(int defaultSize, int& preferredSize) const;
virtual void handleClickEvent(MouseEvent*);
virtual void handleMouseDownEvent(MouseEvent*);
- virtual PassOwnPtr<ClickHandlingState> willDispatchClick();
+ virtual PassOwnPtrWillBeRawPtr<ClickHandlingState> willDispatchClick();
virtual void didDispatchClick(Event*, const ClickHandlingState&);
virtual void handleKeydownEvent(KeyboardEvent*);
virtual void handleKeypressEvent(KeyboardEvent*);
« no previous file with comments | « Source/core/html/forms/CheckboxInputType.cpp ('k') | Source/core/html/forms/InputTypeView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698