runtime/observatory/lib/src/service/object.dart - Issue 2989493002: Simplify and fix implicit closure check, speed up Closure_equals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 2989493002: Simplify and fix implicit closure check, speed up Closure_equals (Closed)

Patch Set: Avoid overloaded NewClosureFunction Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/service/object.dart

diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart

index db31bb76cfafbd94dd3eb6087fde609362e2e0a5..246fba9f85110b8cdf473f2221350a625a9c0b3e 100644

--- a/runtime/observatory/lib/src/service/object.dart

+++ b/runtime/observatory/lib/src/service/object.dart

@@ -3007,6 +3007,8 @@ M.FunctionKind stringToFunctionKind(String value) {

return M.FunctionKind.regular;

case 'ClosureFunction':

return M.FunctionKind.closure;

+ case 'ImplicitClosureFunction':

+ return M.FunctionKind.implicitClosure;

case 'GetterFunction':

return M.FunctionKind.getter;

case 'SetterFunction':