runtime/observatory/lib/src/elements/function_view.dart - Issue 2989493002: Simplify and fix implicit closure check, speed up Closure_equals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/function_view.dart

Issue 2989493002: Simplify and fix implicit closure check, speed up Closure_equals (Closed)

Patch Set: Avoid overloaded NewClosureFunction Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/elements/function_view.dart

diff --git a/runtime/observatory/lib/src/elements/function_view.dart b/runtime/observatory/lib/src/elements/function_view.dart

index ce0a0e3317118c5c2efa3dcd14cda80671f96f3f..a829ded5c81a1f24bb77a1fa8f14ed27d03efc6e 100644

--- a/runtime/observatory/lib/src/elements/function_view.dart

+++ b/runtime/observatory/lib/src/elements/function_view.dart

@@ -399,6 +399,8 @@ class FunctionViewElement extends HtmlElement implements Renderable {

return 'regular';

case M.FunctionKind.closure:

return 'closure';

+ case M.FunctionKind.implicitClosure:

+ return 'implicit closure';

case M.FunctionKind.getter:

return 'getter';

case M.FunctionKind.setter: