Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2989423002: Add add_json_log='on_failure' to json module. (Closed)

Created:
3 years, 4 months ago by stgao
Modified:
3 years, 4 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org, yichunli_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -7 lines) Patch
M README.recipes.md View 1 4 chunks +17 lines, -6 lines 0 comments Download
M recipe_modules/json/api.py View 3 chunks +9 lines, -1 line 0 comments Download
A recipe_modules/json/tests/add_json_log.py View 1 1 chunk +50 lines, -0 lines 0 comments Download
A recipe_modules/json/tests/add_json_log.expected/add_json_log.json View 1 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
stgao
3 years, 4 months ago (2017-08-04 02:49:28 UTC) #2
iannucci
lgtm
3 years, 4 months ago (2017-08-04 18:21:11 UTC) #3
stgao
Hi Robbie, Mind another review for the added tests? Thanks, Shuotao
3 years, 4 months ago (2017-08-04 19:25:24 UTC) #5
iannucci
lgtm
3 years, 4 months ago (2017-08-04 20:54:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2989423002/40001
3 years, 4 months ago (2017-08-04 20:54:47 UTC) #8
commit-bot: I haz the power
3 years, 4 months ago (2017-08-04 21:00:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://github.com/luci/recipes-py/commit/6de52416675972312112322e412f84ae741...

Powered by Google App Engine
This is Rietveld 408576698