Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2989293002: Fix the 'build_all' target for the x64 build. (Closed)

Created:
3 years, 4 months ago by Sébastien Marchand
Modified:
3 years, 4 months ago
Reviewers:
chrisha
CC:
syzygy-changes_googlegroups.com, njanevsk
Target Ref:
refs/heads/master
Project:
syzygy
Visibility:
Public.

Description

Fix the 'build_all' target for the x64 build. Currently the x64 build only supports the SyzyAsan RTL unittests but it'll soon also support building the Clang integration test DLL and so having a build_all target will make it easier to update what gets build on the trybots. Review-Url: https://codereview.chromium.org/2989293002 Committed: https://github.com/google/syzygy/commit/09270be52bd2ffc91556ca58e4a78ef8acddecdf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -63 lines) Patch
M syzygy/syzygy.gyp View 1 chunk +71 lines, -63 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Sébastien Marchand
PTAL.
3 years, 4 months ago (2017-08-02 18:18:25 UTC) #2
chrisha
lgtm
3 years, 4 months ago (2017-08-02 19:44:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2989293002/1
3 years, 4 months ago (2017-08-02 19:44:33 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-08-02 20:35:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/google/syzygy/commit/09270be52bd2ffc91556ca58e4a78ef8acddecdf

Powered by Google App Engine
This is Rietveld 408576698