Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 2989213002: Swarming: final update for OSX temperature reporting (Closed)

Created:
3 years, 4 months ago by M-A Ruel
Modified:
3 years, 4 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, Ken Russell (switch to Gerrit)
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Swarming: final update for OSX temperature reporting - Rename 'cpu0' to 'cpu'. - Rename 'gpu0 diode' to 'gpu' and comment out 'gpu proximity'. - Rename 'power supply C' to 'power supply' and comment out 'power supply P'. The later was not observed in practice. R=vadimsh@chromium.org BUG=749840 Review-Url: https://codereview.chromium.org/2989213002 Committed: https://github.com/luci/luci-py/commit/5d2675b14a7e4901352587f172ac0113033c9235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M appengine/swarming/swarming_bot/api/platforms/osx.py View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
M-A Ruel
Thanks for bearing with me, this should be sufficient to close the issue.
3 years, 4 months ago (2017-08-01 18:38:25 UTC) #1
Vadim Sh.
lgtm
3 years, 4 months ago (2017-08-01 18:39:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2989213002/1
3 years, 4 months ago (2017-08-01 18:43:40 UTC) #4
commit-bot: I haz the power
3 years, 4 months ago (2017-08-01 18:47:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/5d2675b14a7e4901352587f172ac0113033c9235

Powered by Google App Engine
This is Rietveld 408576698