Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2989173002: isolate: pull exparchive and archive into functions with similar signatures. (Closed)

Created:
3 years, 4 months ago by mcgreevy
Modified:
3 years, 4 months ago
Reviewers:
mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

isolate: pull exparchive and archive into functions with similar signatures. BUG=692940 Review-Url: https://codereview.chromium.org/2989173002 Committed: https://github.com/luci/luci-go/commit/258f0c01c308e369ef4d9c96cfddfb25e7944ee9

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -33 lines) Patch
M client/cmd/isolate/archive.go View 3 chunks +33 lines, -19 lines 2 comments Download
M client/cmd/isolate/exp_archive.go View 4 chunks +29 lines, -14 lines 2 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
mcgreevy
3 years, 4 months ago (2017-08-01 07:25:52 UTC) #2
mithro
Generally LGTM. Some minor comments. https://codereview.chromium.org/2989173002/diff/1/client/cmd/isolate/archive.go File client/cmd/isolate/archive.go (right): https://codereview.chromium.org/2989173002/diff/1/client/cmd/isolate/archive.go#newcode101 client/cmd/isolate/archive.go:101: func doArchive(ctx context.Context, client ...
3 years, 4 months ago (2017-08-02 04:28:34 UTC) #3
mcgreevy
https://codereview.chromium.org/2989173002/diff/1/client/cmd/isolate/archive.go File client/cmd/isolate/archive.go (right): https://codereview.chromium.org/2989173002/diff/1/client/cmd/isolate/archive.go#newcode101 client/cmd/isolate/archive.go:101: func doArchive(ctx context.Context, client *isolatedclient.Client, archiveOpts *isolate.ArchiveOptions, quiet bool, ...
3 years, 4 months ago (2017-08-02 05:16:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2989173002/1
3 years, 4 months ago (2017-08-03 06:03:36 UTC) #6
commit-bot: I haz the power
3 years, 4 months ago (2017-08-03 06:07:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/258f0c01c308e369ef4d9c96cfddfb25e7944ee9

Powered by Google App Engine
This is Rietveld 408576698