[fasta] Issue error for large integer literals

[fasta] Issue error for large integer literals

This CL adds error reporting for large integer literals into the
new kernel front-end. It is a part of preparation for limiting
integers to 64 bits in Dart. The new error is reported only
if int.parse() fails to parse integer literal, which could happen
in the --limit-ints-to-64-bits mode.

R=ahe@google.com, scheglov@google.com, sigmund@google.com

Issue: https://github.com/dart-lang/sdk/issues/30103
Committed: https://github.com/dart-lang/sdk/commit/f40ce90eaa43e5728150410673b3695059c2cedf

[alexmarkov, 2017-07-28 19:38:07]

alexmarkov@google.com changed reviewers:
+ asiva@google.com, scheglov@google.com, sigmund@google.com, zra@google.com

[scheglov, 2017-07-28 19:40:30]

LGTM

[Siggi Cherem (dart-lang), 2017-07-28 19:51:42]

Hi Alex, thanks for initiating this change!

Let me follow up with Peter and Florian though - I'd like to have some
specification at hand before we land some of the changes in fasta, or make sure
that we are all on the same page first.  Peter was out this week, but he should
be in starting Monday.

[ahe, 2017-08-01 11:34:12]

ahe@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-08-01 11:34:13]

I'm strongly against adding more language options to our basic tool chains.
Either we commit to a feature or we don't.

The number of test configurations we *should* test grows quadratically in the
number of options we add to our tools. This isn't scalable, and there's
absolutely no way we can commit to not breaking this accidentally.

I'm in favor of having one option, --specification-level that takes two
arguments "1" and "2".

However, this CL isn't affected by this, and I see no reason why this CL
shouldn't be able to land once the minor issues below are addressed.

https://codereview.chromium.org/2989073002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2989073002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1279: } on FormatException
{
Could you use onError error instead?

https://codereview.chromium.org/2989073002/diff/1/pkg/front_end/messages.yaml
File pkg/front_end/messages.yaml (right):

https://codereview.chromium.org/2989073002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:901: template: "Integer literal #lexeme is out of
range"
Add single quotes around #lexeme. See also
pkg/front_end/lib/src/fasta/diagnostics.md.

https://codereview.chromium.org/2989073002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:901: template: "Integer literal #lexeme is out of
range"
Add period at end of sentence.

https://codereview.chromium.org/2989073002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:901: template: "Integer literal #lexeme is out of
range"
A great message conveys the following three things:

1. What is wrong?
2. Why is it wrong?
3. How do I fix it?

[alexmarkov, 2017-08-01 20:14:45]

Hi Peter,

Thank you for the thorough review!

https://codereview.chromium.org/2989073002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2989073002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1279: } on FormatException
{
On 2017/08/01 11:34:13, ahe wrote:
> Could you use onError error instead?

Done.

https://codereview.chromium.org/2989073002/diff/1/pkg/front_end/messages.yaml
File pkg/front_end/messages.yaml (right):

https://codereview.chromium.org/2989073002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:901: template: "Integer literal #lexeme is out of
range"
On 2017/08/01 11:34:13, ahe wrote:
> Add single quotes around #lexeme. See also
> pkg/front_end/lib/src/fasta/diagnostics.md.

Done. Note that pkg/front_end/lib/src/fasta/diagnostics.md says "Do not quote
`null` and numeric literals."

https://codereview.chromium.org/2989073002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:901: template: "Integer literal #lexeme is out of
range"
On 2017/08/01 11:34:13, ahe wrote:
> Add period at end of sentence.

Done.

https://codereview.chromium.org/2989073002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:901: template: "Integer literal #lexeme is out of
range"
On 2017/08/01 11:34:13, ahe wrote:
> A great message conveys the following three things:
> 
> 1. What is wrong?
> 2. Why is it wrong?
> 3. How do I fix it?

Can you suggest an error message for invalid integer literals which would
satisfy these requirements?

[ahe, 2017-08-03 17:10:16]

lgtm

https://codereview.chromium.org/2989073002/diff/1/pkg/front_end/messages.yaml
File pkg/front_end/messages.yaml (right):

https://codereview.chromium.org/2989073002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:901: template: "Integer literal #lexeme is out of
range"
On 2017/08/01 20:14:44, alexmarkov wrote:
> Done. Note that pkg/front_end/lib/src/fasta/diagnostics.md says "Do not quote
> `null` and numeric literals."

Thank you, let's follow what the document says, although it's author can't
remember what it says :-)

https://codereview.chromium.org/2989073002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:901: template: "Integer literal #lexeme is out of
range"
On 2017/08/01 20:14:44, alexmarkov wrote:
> On 2017/08/01 11:34:13, ahe wrote:
> > A great message conveys the following three things:
> > 
> > 1. What is wrong?
> > 2. Why is it wrong?
> > 3. How do I fix it?
> 
> Can you suggest an error message for invalid integer literals which would
> satisfy these requirements?

template: "The integer literal #lexeme can't be represented in 64 bits."
tip: "Try using <what> if you need an integer larger than
9,223,372,036,854,775,807 or less than -9,223,372,036,854,775,808."

[alexmarkov, 2017-08-14 17:56:36]

@Siggi, would it be okay if I land this CL?

https://codereview.chromium.org/2989073002/diff/1/pkg/front_end/messages.yaml
File pkg/front_end/messages.yaml (right):

https://codereview.chromium.org/2989073002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:901: template: "Integer literal #lexeme is out of
range"
On 2017/08/03 17:10:16, ahe wrote:
> On 2017/08/01 20:14:44, alexmarkov wrote:
> > Done. Note that pkg/front_end/lib/src/fasta/diagnostics.md says "Do not
quote
> > `null` and numeric literals."
> 
> Thank you, let's follow what the document says, although it's author can't
> remember what it says :-)

Done.

https://codereview.chromium.org/2989073002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:901: template: "Integer literal #lexeme is out of
range"
On 2017/08/01 20:14:44, alexmarkov wrote:
> On 2017/08/01 11:34:13, ahe wrote:
> > A great message conveys the following three things:
> > 
> > 1. What is wrong?
> > 2. Why is it wrong?
> > 3. How do I fix it?
> 
> Can you suggest an error message for invalid integer literals which would
> satisfy these requirements?

Done.

[Siggi Cherem (dart-lang), 2017-08-14 18:01:26]

lgtm, yes thank you

[alexmarkov, 2017-08-14 18:08:45]

Description was changed from

==========
[fasta] Issue error for large integer literals

This CL adds error reporting for large integer literals into the
new kernel front-end. It is a part of preparation for limiting
integers to 64 bits in Dart. The new error is reported only
if int.parse() fails to parse integer literal, which could happen
in the --limit-ints-to-64-bits mode.

Issue: https://github.com/dart-lang/sdk/issues/30103
==========

to

==========
[fasta] Issue error for large integer literals

This CL adds error reporting for large integer literals into the
new kernel front-end. It is a part of preparation for limiting
integers to 64 bits in Dart. The new error is reported only
if int.parse() fails to parse integer literal, which could happen
in the --limit-ints-to-64-bits mode.

R=ahe@google.com, scheglov@google.com, sigmund@google.com

Issue: https://github.com/dart-lang/sdk/issues/30103
Committed:
https://github.com/dart-lang/sdk/commit/f40ce90eaa43e5728150410673b3695059c2cedf
==========

[alexmarkov, 2017-08-14 18:08:47]

Committed patchset #3 (id:40001) manually as
f40ce90eaa43e5728150410673b3695059c2cedf (presubmit successful).