Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/body_builder.dart

Issue 2989073002: [fasta] Issue error for large integer literals (Closed)
Patch Set: More detailed error message Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/fasta_codes_generated.dart ('k') | pkg/front_end/messages.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/kernel/body_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
index 91569a49a6729c9703a67d87e9cda004316e88b6..2d85a2ebe07b8cef4b9fb8f3b073c512fbd9eae7 100644
--- a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
@@ -1273,8 +1273,14 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
@override
void handleLiteralInt(Token token) {
debugEvent("LiteralInt");
- push(new KernelIntLiteral(int.parse(token.lexeme))
- ..fileOffset = offsetForToken(token));
+ int value = int.parse(token.lexeme, onError: (_) => null);
+ if (value == null) {
+ push(buildCompileTimeError(
+ fasta.templateIntegerLiteralIsOutOfRange.withArguments(token),
+ token.charOffset));
+ } else {
+ push(new KernelIntLiteral(value)..fileOffset = offsetForToken(token));
+ }
}
@override
« no previous file with comments | « pkg/front_end/lib/src/fasta/fasta_codes_generated.dart ('k') | pkg/front_end/messages.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698