Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2989003002: Migrated test block 20 to Dart 2.0. (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 20 to Dart 2.0. No changes to tests, just the following status file updates: Entries for status file /usr/local/google/home/bkonyi/sdk/tests/corelib/corelib.status: [ (($compiler == dart2js) && (bool $dart2js_with_kernel)) ] regexp/invalid-range-in-class_test: Crash regexp/issue_19193_test: Crash regexp/lastindex_test: Crash regexp/lookahead_test: Crash regexp/multiline_test: Crash regexp/negative-special-characters_test: Crash regexp/no-extensions_test: Crash regexp/non-capturing-groups_test: Crash [ ((($compiler == dart2js) && (bool $dart2js_with_kernel)) && (bool $minified)) ] regexp/bol-with-multiline_test: Crash regexp/look-ahead_test: Crash regexp/loop-capture_test: Crash regexp/malformed-escapes_test: Crash regexp/many-brackets_test: Crash regexp/non-bmp_test: Crash regexp/non-capturing-backtracking_test: Crash regexp/non-character_test: Crash regexp/non-greedy-parentheses_test: Crash Entries for status file /usr/local/google/home/bkonyi/sdk/tests/corelib_strong/corelib_strong.status: [ ($compiler == dartdevc) ] regexp/bol-with-multiline_test: RuntimeError # Issue 29921 regexp/invalid-range-in-class_test: RuntimeError # Issue 29921 regexp/look-ahead_test: RuntimeError # Issue 29921 regexp/loop-capture_test: RuntimeError # Issue 29921 regexp/malformed-escapes_test: RuntimeError # Issue 29921 regexp/many-brackets_test: RuntimeError # Issue 29921 regexp/negative-special-characters_test: RuntimeError # Issue 29921 regexp/no-extensions_test: RuntimeError # Issue 29921 regexp/non-bmp_test: RuntimeError # Issue 29921 regexp/non-capturing-backtracking_test: RuntimeError # Issue 29921 regexp/non-capturing-groups_test: RuntimeError # Issue 29921 regexp/non-character_test: RuntimeError # Issue 29921 regexp/non-greedy-parentheses_test: RuntimeError # Issue 29921 BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/814edbe8963457e4b44a0b71bc527b623a867d67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1952 lines) Patch
M tests/corelib/corelib.status View 3 chunks +0 lines, -17 lines 0 comments Download
D tests/corelib/regexp/invalid-range-in-class_test.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D tests/corelib/regexp/issue_19193_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/corelib/regexp/lastindex_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/corelib/regexp/look-ahead_test.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D tests/corelib/regexp/lookahead_test.dart View 1 chunk +0 lines, -162 lines 0 comments Download
D tests/corelib/regexp/loop-capture_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/corelib/regexp/malformed-escapes_test.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D tests/corelib/regexp/many-brackets_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/corelib/regexp/multiline_test.dart View 1 chunk +0 lines, -114 lines 0 comments Download
D tests/corelib/regexp/negative-special-characters_test.dart View 1 chunk +0 lines, -95 lines 0 comments Download
D tests/corelib/regexp/no-extensions_test.dart View 1 chunk +0 lines, -94 lines 0 comments Download
D tests/corelib/regexp/non-bmp_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D tests/corelib/regexp/non-capturing-backtracking_test.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D tests/corelib/regexp/non-capturing-groups_test.dart View 1 chunk +0 lines, -49 lines 0 comments Download
D tests/corelib/regexp/non-character_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D tests/corelib/regexp/non-greedy-parentheses_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 3 chunks +30 lines, -0 lines 0 comments Download
A + tests/corelib_2/regexp/invalid-range-in-class_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/issue_19193_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/lastindex_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/look-ahead_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/lookahead_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/loop-capture_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/malformed-escapes_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/many-brackets_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/multiline_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/negative-special-characters_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/no-extensions_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/non-bmp_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/non-capturing-backtracking_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/non-capturing-groups_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/non-character_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/non-greedy-parentheses_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 2 chunks +0 lines, -13 lines 0 comments Download
D tests/corelib_strong/regexp/invalid-range-in-class_test.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D tests/corelib_strong/regexp/issue_19193_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/corelib_strong/regexp/lastindex_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/corelib_strong/regexp/look-ahead_test.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D tests/corelib_strong/regexp/lookahead_test.dart View 1 chunk +0 lines, -162 lines 0 comments Download
D tests/corelib_strong/regexp/loop-capture_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/corelib_strong/regexp/malformed-escapes_test.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D tests/corelib_strong/regexp/many-brackets_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/corelib_strong/regexp/multiline_test.dart View 1 chunk +0 lines, -114 lines 0 comments Download
D tests/corelib_strong/regexp/negative-special-characters_test.dart View 1 chunk +0 lines, -95 lines 0 comments Download
D tests/corelib_strong/regexp/no-extensions_test.dart View 1 chunk +0 lines, -94 lines 0 comments Download
D tests/corelib_strong/regexp/non-bmp_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D tests/corelib_strong/regexp/non-capturing-backtracking_test.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D tests/corelib_strong/regexp/non-capturing-groups_test.dart View 1 chunk +0 lines, -49 lines 0 comments Download
D tests/corelib_strong/regexp/non-character_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D tests/corelib_strong/regexp/non-greedy-parentheses_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (3 generated)
bkonyi
3 years, 4 months ago (2017-07-27 19:46:00 UTC) #2
Bob Nystrom
lgtm
3 years, 4 months ago (2017-07-27 22:50:06 UTC) #4
bkonyi
3 years, 4 months ago (2017-07-28 19:52:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
814edbe8963457e4b44a0b71bc527b623a867d67.

Powered by Google App Engine
This is Rietveld 408576698