Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 2989843002: Migrated test block 21 to Dart 2.0. (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 21 to Dart 2.0. No changes made to tests. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/4f33acda8a4aa6938052bb3ac460237345b350be

Patch Set 1 #

Patch Set 2 : Migrated test block 20 to Dart 2.0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -871 lines) Patch
D tests/corelib/regexp/norepeat_test.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D tests/corelib/regexp/overflow_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D tests/corelib/regexp/parentheses_test.dart View 1 chunk +0 lines, -358 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 3 chunks +6 lines, -0 lines 0 comments Download
A + tests/corelib_2/regexp/norepeat_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/overflow_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/parentheses_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/corelib_strong/regexp/norepeat_test.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D tests/corelib_strong/regexp/overflow_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D tests/corelib_strong/regexp/parentheses_test.dart View 1 chunk +0 lines, -358 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
3 years, 4 months ago (2017-07-27 19:54:06 UTC) #2
Bob Nystrom
lgtm
3 years, 4 months ago (2017-07-27 22:50:44 UTC) #3
bkonyi
3 years, 4 months ago (2017-07-28 20:10:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4f33acda8a4aa6938052bb3ac460237345b350be.

Powered by Google App Engine
This is Rietveld 408576698