Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2988993003: [logdog-view] Update UX, fix bugs. (Closed)

Created:
3 years, 4 months ago by dnj
Modified:
3 years, 4 months ago
Reviewers:
Ryan Tseng, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[logdog-view] Update UX, fix bugs. Update the LogDog Web Viewer user experience and fix a bug where the stream finishing wasn't always acknowledged by the UI. This makes button visibility modal. While the stream is automatically loading, control buttons will be hidden. When it is paused, they will be shown. This will reduce the number of active buttons that the user has to see during log interaction. Following is no longer optional. It is enabled by default, and disabled permanently for the duration of the stream on scroll or pause. This removes the need for a user to manage this option. BUG=None TEST=local Review-Url: https://codereview.chromium.org/2988993003 Committed: https://github.com/luci/luci-go/commit/810e5dc1dfbe94f009ae3cd5e0d3c92d1a375d88

Patch Set 1 #

Patch Set 2 : formatting #

Patch Set 3 : [logdog-view] Update UX, fix bugs. #

Patch Set 4 : [logdog-view] Update UX, fix bugs. #

Patch Set 5 : cleanup #

Patch Set 6 : last #

Total comments: 2

Patch Set 7 : unfollow only on up scroll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -212 lines) Patch
M web/inc/logdog-stream-view/logdog-stream-view.html View 1 2 3 4 5 6 13 chunks +45 lines, -99 lines 0 comments Download
M web/inc/logdog-stream-view/model.ts View 1 2 12 chunks +43 lines, -44 lines 0 comments Download
M web/inc/logdog-stream-view/view.ts View 1 2 3 4 5 6 15 chunks +106 lines, -69 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
dnj
formatting
3 years, 4 months ago (2017-07-28 13:49:24 UTC) #1
dnj
PTAL
3 years, 4 months ago (2017-08-01 18:18:54 UTC) #3
dnj
Example: https://dev-dot-luci-logdog.appspot.com/v/?h=luci-logdog.appspot.com&s=chromium%2Fbb%2Fchromium%2FWin%2F57593%2F%2B%2Frecipes%2Fsteps%2Fbot_update%2F0%2Fstdout
3 years, 4 months ago (2017-08-01 18:26:28 UTC) #4
Ryan Tseng
lgtm https://codereview.chromium.org/2988993003/diff/100001/web/inc/logdog-stream-view/view.ts File web/inc/logdog-stream-view/view.ts (right): https://codereview.chromium.org/2988993003/diff/100001/web/inc/logdog-stream-view/view.ts#newcode183 web/inc/logdog-stream-view/view.ts:183: handleMouseWheel() { I'd probably only handle this if ...
3 years, 4 months ago (2017-08-01 18:39:07 UTC) #6
dnj
https://codereview.chromium.org/2988993003/diff/100001/web/inc/logdog-stream-view/view.ts File web/inc/logdog-stream-view/view.ts (right): https://codereview.chromium.org/2988993003/diff/100001/web/inc/logdog-stream-view/view.ts#newcode183 web/inc/logdog-stream-view/view.ts:183: handleMouseWheel() { On 2017/08/01 18:39:07, Ryan Tseng wrote: > ...
3 years, 4 months ago (2017-08-01 20:16:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2988993003/120001
3 years, 4 months ago (2017-08-01 20:16:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Win Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/37b842e65f0df310)
3 years, 4 months ago (2017-08-01 20:20:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2988993003/120001
3 years, 4 months ago (2017-08-01 22:24:23 UTC) #14
commit-bot: I haz the power
3 years, 4 months ago (2017-08-01 22:31:27 UTC) #17
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://github.com/luci/luci-go/commit/810e5dc1dfbe94f009ae3cd5e0d3c92d1a375d88

Powered by Google App Engine
This is Rietveld 408576698