Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2988923002: Revert of The Appcache subresource URL factory needs to inform the URLLoaderClient if there is a failure. (Closed)

Created:
3 years, 4 months ago by mmenke
Modified:
3 years, 4 months ago
Reviewers:
michaeln, jam, ananta
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of The Appcache subresource URL factory needs to inform the URLLoaderClient if there is a failure. (patchset #7 id:120001 of https://codereview.chromium.org/2991443002/ ) Reason for revert: AppCacheNetworkServiceBrowserTest.VerifySubresourceFactoryClearedOnNewNavigation is very flaky, with a lot of red try runs on the CQ and the builders. Windows CQ has a 2 hour backlog (Or did earlier), and while this isn't the only reason, it looks like a major contributor. Original issue's description: > The Appcache subresource URL factory needs to inform the URLLoaderClient if there is a failure. > > Failure cases include, an invalid AppCacheHost instance, failure to create a request handler, etc. > We already notify the client about the latter case above. Need to do this for an invalid host as well. > This caused the w3schools AppCache test page to spin indefinitely if we pass in an invalid URL. > > Additionally on the renderer side we need to reset the cached URLLoaderFactory pointer if a null factory > is passed in the CommitNavigation IPC. This ensures that the request hits the default network loader. > > BUG=715632 > TEST=Covered by browser test. AppCacheNetworkServiceBrowserTest.VerifySubresourceFactoryClearedOnNewNavigation > > Review-Url: https://codereview.chromium.org/2991443002 > Cr-Commit-Position: refs/heads/master@{#489710} > Committed: https://chromium.googlesource.com/chromium/src/+/4a9dd98efab25e78f28b800520c1868aaad2cb1f TBR=jam@chromium.org,michaeln@chromium.org,ananta@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=715632 Review-Url: https://codereview.chromium.org/2988923002 Cr-Commit-Position: refs/heads/master@{#489860} Committed: https://chromium.googlesource.com/chromium/src/+/a08d0fc015c42ce95a104c0f4e3de9448b7721e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -167 lines) Patch
D content/browser/appcache/appcache_browsertest.cc View 1 chunk +0 lines, -104 lines 0 comments Download
M content/browser/appcache/appcache_subresource_url_factory.h View 3 chunks +1 line, -9 lines 0 comments Download
M content/browser/appcache/appcache_subresource_url_factory.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M content/browser/appcache/appcache_url_loader_job.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D content/test/data/appcache/logo.png View Binary file 0 comments Download
D content/test/data/appcache/simple_page.manifest View 1 chunk +0 lines, -2 lines 0 comments Download
D content/test/data/appcache/simple_page_no_manifest.html View 1 chunk +0 lines, -10 lines 0 comments Download
D content/test/data/appcache/simple_page_with_manifest.html View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
mmenke
3 years, 4 months ago (2017-07-27 04:46:06 UTC) #2
Created Revert of The Appcache subresource URL factory needs to inform the
URLLoaderClient if there is a failure.

Powered by Google App Engine
This is Rietveld 408576698