DescriptionRevert of The Appcache subresource URL factory needs to inform the URLLoaderClient if there is a failure. (patchset #7 id:120001 of https://codereview.chromium.org/2991443002/ )
Reason for revert:
AppCacheNetworkServiceBrowserTest.VerifySubresourceFactoryClearedOnNewNavigation is very flaky, with a lot of red try runs on the CQ and the builders.
Windows CQ has a 2 hour backlog (Or did earlier), and while this isn't the only reason, it looks like a major contributor.
Original issue's description:
> The Appcache subresource URL factory needs to inform the URLLoaderClient if there is a failure.
>
> Failure cases include, an invalid AppCacheHost instance, failure to create a request handler, etc.
> We already notify the client about the latter case above. Need to do this for an invalid host as well.
> This caused the w3schools AppCache test page to spin indefinitely if we pass in an invalid URL.
>
> Additionally on the renderer side we need to reset the cached URLLoaderFactory pointer if a null factory
> is passed in the CommitNavigation IPC. This ensures that the request hits the default network loader.
>
> BUG=715632
> TEST=Covered by browser test. AppCacheNetworkServiceBrowserTest.VerifySubresourceFactoryClearedOnNewNavigation
>
> Review-Url: https://codereview.chromium.org/2991443002
> Cr-Commit-Position: refs/heads/master@{#489710}
> Committed: https://chromium.googlesource.com/chromium/src/+/4a9dd98efab25e78f28b800520c1868aaad2cb1f
TBR=jam@chromium.org,michaeln@chromium.org,ananta@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=715632
Review-Url: https://codereview.chromium.org/2988923002
Cr-Commit-Position: refs/heads/master@{#489860}
Committed: https://chromium.googlesource.com/chromium/src/+/a08d0fc015c42ce95a104c0f4e3de9448b7721e1
Patch Set 1 #Messages
Total messages: 3 (2 generated)
|