Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2988753002: Revert of Migrate BrowserAccessibility windows unique id handling to AXPlatformNodeWin. (Closed)

Created:
3 years, 5 months ago by dougt
Modified:
3 years, 5 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, aleventhal+watch_chromium.org, dtseng+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Migrate BrowserAccessibility windows unique id handling to AXPlatformNodeWin. (patchset #4 id:80001 of https://codereview.chromium.org/2981083002/ ) Reason for revert: Revert due to crbug 748472. Will reland w/ fix after merge to M61 branch. Original issue's description: > Migrate BrowserAccessibility windows unique id handling to AXPlatformNodeWin. > > Global identifiers are allocated out of ui::GetNextAXPlatformNodeUniqueId > currently. Both BrowserAccessibility and the AXPlatform code both independently > Assign a unique id during object creation. > > What we want to have happen is for the BrowserAccessibilityComWin class, > and it�s typical owner, the BrowserAccessibilityWin, to share the same unique > id. This makes it easier to reason about as well as necessary to be able to > Implement get_uniqueID(). > > This CL makes private the |unique_id_| used in both above base classes private > and forces all access through virtual class methods. The BrowserAccessibilityWin > overrides and implements in terms of AXPlatformNodeWin. > > BUG=703369 > > Review-Url: https://codereview.chromium.org/2981083002 > Cr-Commit-Position: refs/heads/master@{#489177} > Committed: https://chromium.googlesource.com/chromium/src/+/8b5355784ac527145920d375a2065537c76dea01 TBR=dmazzoni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=703369 Review-Url: https://codereview.chromium.org/2988753002 Cr-Commit-Position: refs/heads/master@{#489342} Committed: https://chromium.googlesource.com/chromium/src/+/ba05045c920078d04b7135144dd14c649bc73727

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -133 lines) Patch
M content/browser/accessibility/browser_accessibility.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 3 chunks +29 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_android.h View 3 chunks +0 lines, -6 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_android.cc View 3 chunks +1 line, -27 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_com_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_com_win.cc View 8 chunks +17 lines, -11 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_event.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.cc View 3 chunks +12 lines, -14 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 9 chunks +12 lines, -24 lines 0 comments Download
M content/browser/accessibility/web_contents_accessibility_android.cc View 7 chunks +9 lines, -22 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node.cc View 1 chunk +25 lines, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.cc View 3 chunks +1 line, -22 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dougt
Created Revert of Migrate BrowserAccessibility windows unique id handling to AXPlatformNodeWin.
3 years, 5 months ago (2017-07-25 16:29:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2988753002/1
3 years, 5 months ago (2017-07-25 16:29:40 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-07-25 16:29:42 UTC) #5
dmazzoni
lgtm
3 years, 5 months ago (2017-07-25 16:55:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2988753002/1
3 years, 5 months ago (2017-07-25 16:57:50 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-25 16:58:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ba05045c920078d04b7135144dd1...

Powered by Google App Engine
This is Rietveld 408576698