Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2988743002: Remove the analysus.reanalyze request from the plugin API (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the analysus.reanalyze request from the plugin API R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/8bbf373a5ebee155d3a557ec74ece76582727218

Patch Set 1 #

Patch Set 2 : Restart plugins #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -297 lines) Patch
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/plugin_manager.dart View 1 2 chunks +56 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/request_converter.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/analysis/reanalyze_test.dart View 1 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/plugin_manager_test.dart View 1 1 chunk +39 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/doc/api.html View 3 chunks +1 line, -28 lines 0 comments Download
M pkg/analyzer_plugin/lib/plugin/plugin.dart View 2 chunks +0 lines, -37 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol_constants.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol_generated.dart View 1 chunk +0 lines, -117 lines 0 comments Download
M pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart View 1 chunk +0 lines, -22 lines 0 comments Download
M pkg/analyzer_plugin/test/integration/support/protocol_matchers.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M pkg/analyzer_plugin/test/plugin/plugin_test.dart View 2 chunks +0 lines, -36 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/plugin_spec.html View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 5 months ago (2017-07-25 19:05:42 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-07-25 19:09:24 UTC) #3
Brian Wilkerson
3 years, 5 months ago (2017-07-25 19:10:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8bbf373a5ebee155d3a557ec74ece76582727218 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698