Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: pkg/analyzer_plugin/lib/plugin/plugin.dart

Issue 2988743002: Remove the analysus.reanalyze request from the plugin API (Closed)
Patch Set: Restart plugins Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer_plugin/doc/api.html ('k') | pkg/analyzer_plugin/lib/protocol/protocol_constants.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_plugin/lib/plugin/plugin.dart
diff --git a/pkg/analyzer_plugin/lib/plugin/plugin.dart b/pkg/analyzer_plugin/lib/plugin/plugin.dart
index 7ff013d76b5f5a674f03cb9bae6186871f60a485..ecffd5e76ce068b5500661d411023b0d55eb3528 100644
--- a/pkg/analyzer_plugin/lib/plugin/plugin.dart
+++ b/pkg/analyzer_plugin/lib/plugin/plugin.dart
@@ -235,39 +235,6 @@ abstract class ServerPlugin {
}
/**
- * Handle an 'analysis.reanalyze' request.
- */
- Future<AnalysisReanalyzeResult> handleAnalysisReanalyze(
- AnalysisReanalyzeParams parameters) async {
- List<String> rootPaths = parameters.roots;
- if (rootPaths == null) {
- //
- // Reanalyze everything.
- //
- List<ContextRoot> roots = driverMap.keys.toList();
- for (ContextRoot contextRoot in roots) {
- AnalysisDriverGeneric driver = driverMap[contextRoot];
- driver.dispose();
- driver = createAnalysisDriver(contextRoot);
- driverMap[contextRoot] = driver;
- }
- return new AnalysisReanalyzeResult();
- } else {
- //
- // Reanalyze a specific set of files.
- //
- // TODO(brianwilkerson) There is no API for telling a driver that we need
- // to have some files reanalyzed.
-// for (String rootPath in rootPaths) {
-// ContextRoot contextRoot = contextRootContaining(rootPath);
-// AnalysisDriverGeneric driver = driverMap[contextRoot];
-// driver.reanalyze(rootPath);
-// }
- return null;
- }
- }
-
- /**
* Handle an 'analysis.setContextRoots' request.
*/
Future<AnalysisSetContextRootsResult> handleAnalysisSetContextRoots(
@@ -507,10 +474,6 @@ abstract class ServerPlugin {
var params = new AnalysisHandleWatchEventsParams.fromRequest(request);
result = await handleAnalysisHandleWatchEvents(params);
break;
- case ANALYSIS_REQUEST_REANALYZE:
- var params = new AnalysisReanalyzeParams.fromRequest(request);
- result = await handleAnalysisReanalyze(params);
- break;
case ANALYSIS_REQUEST_SET_CONTEXT_ROOTS:
var params = new AnalysisSetContextRootsParams.fromRequest(request);
result = await handleAnalysisSetContextRoots(params);
« no previous file with comments | « pkg/analyzer_plugin/doc/api.html ('k') | pkg/analyzer_plugin/lib/protocol/protocol_constants.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698