Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2988733002: swarming: fix invalid events on task retry (Closed)

Created:
3 years, 5 months ago by M-A Ruel
Modified:
3 years, 5 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

swarming: fix invalid events on task retry When a TaskRunResult failed with an internal error but the TaskResultSummary is still PENDING/RUNNING, an event would be sent which would eventually lead to an error like: Unhandled task state 16 Check the summary result, not the run result, for completion. R=vadimsh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2988733002 Committed: https://github.com/luci/luci-py/commit/f107153714a977dc247ea60d0caca0856bee6959

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M appengine/swarming/server/task_scheduler.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
M-A Ruel
3 years, 5 months ago (2017-07-25 15:23:05 UTC) #1
Vadim Sh.
lgtm
3 years, 5 months ago (2017-07-25 16:41:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2988733002/1
3 years, 5 months ago (2017-07-25 16:57:22 UTC) #4
commit-bot: I haz the power
3 years, 5 months ago (2017-07-25 17:01:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/f107153714a977dc247ea60d0caca0856bee6959

Powered by Google App Engine
This is Rietveld 408576698