Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5106)

Unified Diff: chrome/browser/resources/inspect/inspect.js

Issue 298873007: DevTools: Allow closing targets (workers and remote pages) even if the target is being inspected (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/device/devtools_android_bridge.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/inspect/inspect.js
diff --git a/chrome/browser/resources/inspect/inspect.js b/chrome/browser/resources/inspect/inspect.js
index b2ba0b8d8e3cbaf973d9b52213b6777ad9d5f2e1..cafb82667c4fa0ea0a2b439c6c030c7589ca8fae 100644
--- a/chrome/browser/resources/inspect/inspect.js
+++ b/chrome/browser/resources/inspect/inspect.js
@@ -379,7 +379,7 @@ function populateRemoteTargets(devices) {
}
if (majorChromeVersion >= MIN_VERSION_TAB_CLOSE) {
addActionLink(row, 'close',
- sendTargetCommand.bind(null, 'close', page), page.attached);
+ sendTargetCommand.bind(null, 'close', page), false);
}
}
}
@@ -419,7 +419,7 @@ function addToWorkersList(data) {
var row =
addTargetToList(data, $('workers-list'), ['name', 'description', 'url']);
addActionLink(row, 'terminate',
- sendTargetCommand.bind(null, 'close', data), data.attached);
+ sendTargetCommand.bind(null, 'close', data), false);
}
function addToOthersList(data) {
« no previous file with comments | « chrome/browser/devtools/device/devtools_android_bridge.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698