chrome/browser/devtools/device/devtools_android_bridge.cc - Issue 298873007: DevTools: Allow closing targets (workers and remote pages) even if the target is being inspected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/devtools_android_bridge.cc

Issue 298873007: DevTools: Allow closing targets (workers and remote pages) even if the target is being inspected (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/device/devtools_android_bridge.cc

diff --git a/chrome/browser/devtools/device/devtools_android_bridge.cc b/chrome/browser/devtools/device/devtools_android_bridge.cc

index 71257c644e61d6098d91771b5b1df0bd67ac137d..106a64f270d6de2d0c1ead914c503be9124c28fb 100644

--- a/chrome/browser/devtools/device/devtools_android_bridge.cc

+++ b/chrome/browser/devtools/device/devtools_android_bridge.cc

@@ -558,8 +558,6 @@ bool RemotePageTarget::Activate() const {

}

bool RemotePageTarget::Close() const {

- if (IsAttached())

- return false;

std::string request = base::StringPrintf(kClosePageRequest,

remote_id_.c_str());

browser_->SendJsonRequest(request, base::Bind(&NoOp));

« no previous file with comments | « no previous file | chrome/browser/resources/inspect/inspect.js » ('j') | no next file with comments »