Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 298873007: DevTools: Allow closing targets (workers and remote pages) even if the target is being inspected (Closed)

Created:
6 years, 7 months ago by Vladislav Kaznacheev
Modified:
6 years, 6 months ago
Reviewers:
yurys
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, arv+watch_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

DevTools: Allow closing targets (workers and remote pages) even if the target is being inspected BUG=375679 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272872

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/browser/devtools/device/devtools_android_bridge.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/inspect/inspect.js View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Vladislav Kaznacheev
6 years, 7 months ago (2014-05-23 13:38:07 UTC) #1
yurys
lgtm
6 years, 7 months ago (2014-05-26 05:11:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/298873007/1
6 years, 7 months ago (2014-05-26 05:11:38 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-26 06:48:00 UTC) #4
Vladislav Kaznacheev
The CQ bit was checked by kaznacheev@chromium.org
6 years, 7 months ago (2014-05-26 12:24:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/298873007/40001
6 years, 7 months ago (2014-05-26 12:24:57 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-26 14:25:06 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-05-26 20:07:15 UTC) #8
Message was sent while issue was closed. 
Change committed as 272872

Powered by Google App Engine
This is Rietveld 408576698