Source/core/dom/Document.cpp - Issue 298863010: Oilpan: have PendingScripts trace their script elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.cpp

Issue 298863010: Oilpan: have PendingScripts trace their script elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add PendingScript::m_element comment + GC plugin annotation. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index e424d1f1399550161bff37c2e8d6f5504fa2ad30..c982ed6d23a91816f6f8d3d5358c16af62e43a4d 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -5761,6 +5761,14 @@ void Document::trace(Visitor* visitor)

visitor->trace(m_titleElement);

visitor->trace(m_markers);

visitor->trace(m_currentScriptStack);

+#if ENABLE(OILPAN)

Mads Ager (chromium) 2014/05/26 13:55:36 Nit: We are beginning to have multiple ifdef block

+ // FIXME: Oilpan: m_scriptRunner is a traced OwnPtr. This is done

+ // so as to allow its destructor to refer to its 'host' (this

+ // Document object) when tidying up.

+ //

+ // See PendingScript::trace() comment for more background.

+ visitor->trace(m_scriptRunner);

+#endif

visitor->trace(m_transformSourceDocument);

visitor->trace(m_listsInvalidatedAtDocument);

#if ENABLE(OILPAN)

« no previous file with comments | « no previous file | Source/core/dom/PendingScript.h » ('j') | Source/core/dom/PendingScript.h » ('J')