Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 298863010: Oilpan: have PendingScripts trace their script elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add PendingScript::m_element comment + GC plugin annotation. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/dom/PendingScript.h » ('j') | Source/core/dom/PendingScript.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 5743 matching lines...) Expand 10 before | Expand all | Expand 10 after
5754 visitor->trace(m_docType); 5754 visitor->trace(m_docType);
5755 visitor->trace(m_implementation); 5755 visitor->trace(m_implementation);
5756 visitor->trace(m_autofocusElement); 5756 visitor->trace(m_autofocusElement);
5757 visitor->trace(m_focusedElement); 5757 visitor->trace(m_focusedElement);
5758 visitor->trace(m_hoverNode); 5758 visitor->trace(m_hoverNode);
5759 visitor->trace(m_activeHoverElement); 5759 visitor->trace(m_activeHoverElement);
5760 visitor->trace(m_documentElement); 5760 visitor->trace(m_documentElement);
5761 visitor->trace(m_titleElement); 5761 visitor->trace(m_titleElement);
5762 visitor->trace(m_markers); 5762 visitor->trace(m_markers);
5763 visitor->trace(m_currentScriptStack); 5763 visitor->trace(m_currentScriptStack);
5764 #if ENABLE(OILPAN)
Mads Ager (chromium) 2014/05/26 13:55:36 Nit: We are beginning to have multiple ifdef block
5765 // FIXME: Oilpan: m_scriptRunner is a traced OwnPtr. This is done
5766 // so as to allow its destructor to refer to its 'host' (this
5767 // Document object) when tidying up.
5768 //
5769 // See PendingScript::trace() comment for more background.
5770 visitor->trace(m_scriptRunner);
5771 #endif
5764 visitor->trace(m_transformSourceDocument); 5772 visitor->trace(m_transformSourceDocument);
5765 visitor->trace(m_listsInvalidatedAtDocument); 5773 visitor->trace(m_listsInvalidatedAtDocument);
5766 #if ENABLE(OILPAN) 5774 #if ENABLE(OILPAN)
5767 for (int i = 0; i < numNodeListInvalidationTypes; ++i) 5775 for (int i = 0; i < numNodeListInvalidationTypes; ++i)
5768 visitor->trace(m_nodeLists[i]); 5776 visitor->trace(m_nodeLists[i]);
5769 #endif 5777 #endif
5770 visitor->trace(m_cssCanvasElements); 5778 visitor->trace(m_cssCanvasElements);
5771 visitor->trace(m_topLayerElements); 5779 visitor->trace(m_topLayerElements);
5772 visitor->trace(m_elemSheet); 5780 visitor->trace(m_elemSheet);
5773 visitor->trace(m_nodeIterators); 5781 visitor->trace(m_nodeIterators);
(...skipping 13 matching lines...) Expand all
5787 visitor->trace(m_timeline); 5795 visitor->trace(m_timeline);
5788 visitor->trace(m_compositorPendingAnimations); 5796 visitor->trace(m_compositorPendingAnimations);
5789 visitor->registerWeakMembers<Document, &Document::clearWeakMembers>(this); 5797 visitor->registerWeakMembers<Document, &Document::clearWeakMembers>(this);
5790 DocumentSupplementable::trace(visitor); 5798 DocumentSupplementable::trace(visitor);
5791 TreeScope::trace(visitor); 5799 TreeScope::trace(visitor);
5792 ContainerNode::trace(visitor); 5800 ContainerNode::trace(visitor);
5793 ExecutionContext::trace(visitor); 5801 ExecutionContext::trace(visitor);
5794 } 5802 }
5795 5803
5796 } // namespace WebCore 5804 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/PendingScript.h » ('j') | Source/core/dom/PendingScript.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698