[path] Fix root path mocking.

[path] Fix root path mocking.

Currently, mocking a root path (e.g., "/foo/bar") will result in
infinite recursion due to dirname on the root element equalling itself.
Fix this by detecting when a "dirname" yields itself and observing this
as a terminal condition.

BUG=None
TEST=expectations
R=iannucci@chromium.org, vadimsh@chromium.org

Review-Url: https://codereview.chromium.org/2988583002
Committed: https://github.com/luci/recipes-py/commit/8e8339afbdb986a9195a97cb2c173984bdd4b758

[Vadim Sh., 2017-07-23 19:38:47]

lgtm

[dnj, 2017-07-24 09:51:48]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2017-07-24 09:51:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-24 09:59:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-24 09:59:49]

Try jobs failed on following builders:
  Recipes-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/378cd8534dbc8910)

[dnj, 2017-07-24 10:04:13]

use real paths

[dnj, 2017-07-24 10:04:20]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-07-24 10:04:21]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2988583002/#ps20001
(title: "use real paths")

[commit-bot: I haz the power, 2017-07-24 10:04:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-24 10:11:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-24 10:11:20]

Try jobs failed on following builders:
  Recipes-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/378ce2dd6e959e10)

[iannucci, 2017-07-24 10:14:34]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2017-07-24 10:14:35]

lgtm

[commit-bot: I haz the power, 2017-07-24 10:14:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-24 10:18:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1500891274958700,
"parent_rev": "00799cc803d08da72548d3a5dc441771576cd72a", "commit_rev":
"8e8339afbdb986a9195a97cb2c173984bdd4b758"}

[commit-bot: I haz the power, 2017-07-24 10:18:14]

Description was changed from

==========
[path] Fix root path mocking.

Currently, mocking a root path (e.g., "/foo/bar") will result in
infinite recursion due to dirname on the root element equalling itself.
Fix this by detecting when a "dirname" yields itself and observing this
as a terminal condition.

BUG=None
TEST=expectations
R=iannucci@chromium.org, vadimsh@chromium.org
==========

to

==========
[path] Fix root path mocking.

Currently, mocking a root path (e.g., "/foo/bar") will result in
infinite recursion due to dirname on the root element equalling itself.
Fix this by detecting when a "dirname" yields itself and observing this
as a terminal condition.

BUG=None
TEST=expectations
R=iannucci@chromium.org, vadimsh@chromium.org

Review-Url: https://codereview.chromium.org/2988583002
Committed:
https://github.com/luci/recipes-py/commit/8e8339afbdb986a9195a97cb2c173984bdd...
==========

[commit-bot: I haz the power, 2017-07-24 10:18:15]

Committed patchset #2 (id:20001) as
https://github.com/luci/recipes-py/commit/8e8339afbdb986a9195a97cb2c173984bdd...