Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 2988553002: Fixed errors related to bad-continuation pt.11 (Closed)

Created:
3 years, 5 months ago by Lo-Lo
Modified:
3 years, 5 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Fixed errors related to bad-continuation Fixed pylint errors in: telemetry/telemetry/internal/browser/browser_unittest.py telemetry/telemetry/internal/image_processing/image_util_numpy_impl.py telemetry/telemetry/internal/platform/cros_platform_backend_unittest.py telemetry/telemetry/internal/platform/device_finder.py Part 11 BUG=catapult:#3604 Review-Url: https://codereview.chromium.org/2988553002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/fc0d6193dd7ae707f7c16130713cf5d688073be1

Patch Set 1 #

Patch Set 2 : Fixed additional errors #

Patch Set 3 : Removed pylintrc changes #

Patch Set 4 : Fix additional errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -26 lines) Patch
M telemetry/telemetry/internal/browser/browser_unittest.py View 3 chunks +5 lines, -5 lines 0 comments Download
M telemetry/telemetry/internal/image_processing/image_util_numpy_impl.py View 1 chunk +3 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/platform/cros_platform_backend_unittest.py View 1 2 3 1 chunk +18 lines, -16 lines 0 comments Download
M telemetry/telemetry/internal/platform/device_finder.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 43 (37 generated)
Lo-Lo
Hey, Fixed additional errors related to the bad-continuation param. Please review. - Lori
3 years, 5 months ago (2017-07-24 19:57:27 UTC) #34
ashleymarie1
On 2017/07/24 19:57:27, Lo-Lo wrote: > Hey, > > Fixed additional errors related to the ...
3 years, 5 months ago (2017-07-24 20:00:23 UTC) #35
nednguyen
On 2017/07/24 20:00:23, ashleymarie1 wrote: > On 2017/07/24 19:57:27, Lo-Lo wrote: > > Hey, > ...
3 years, 5 months ago (2017-07-24 21:37:52 UTC) #36
Lo-Lo
On 2017/07/24 21:37:52, nednguyen wrote: > On 2017/07/24 20:00:23, ashleymarie1 wrote: > > On 2017/07/24 ...
3 years, 5 months ago (2017-07-24 21:41:48 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2988553002/60001
3 years, 5 months ago (2017-07-24 21:43:22 UTC) #40
commit-bot: I haz the power
3 years, 5 months ago (2017-07-24 21:45:20 UTC) #43
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698