Media Galleries: Refactor DeviceMediaAsyncFileUtil.

Media Galleries: Refactor DeviceMediaAsyncFileUtil.

And other misc cleanups.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272239

[Lei Zhang, 2014-05-21 08:39:02]

prep work for bug 367029

[vandebo (ex-Chrome), 2014-05-21 18:46:46]

LGTM

https://codereview.chromium.org/298843002/diff/40001/chrome/browser/media_gal...
File chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc
(right):

https://codereview.chromium.org/298843002/diff/40001/chrome/browser/media_gal...
chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc:183:
return delegate ? delegate->IsStreaming() : false;
nit: this seems less readable.

[Lei Zhang, 2014-05-21 19:04:37]

https://codereview.chromium.org/298843002/diff/40001/chrome/browser/media_gal...
File chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc
(right):

https://codereview.chromium.org/298843002/diff/40001/chrome/browser/media_gal...
chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc:183:
return delegate ? delegate->IsStreaming() : false;
On 2014/05/21 18:46:46, vandebo wrote:
> nit: this seems less readable.

*shrug* revert

[Lei Zhang, 2014-05-21 19:05:13]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-05-21 19:58:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/298843002/60001

[commit-bot: I haz the power, 2014-05-22 10:51:45]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/10898)

[commit-bot: I haz the power, 2014-05-22 13:58:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 13:58:10]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[Lei Zhang, 2014-05-22 18:13:04]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-05-22 18:13:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/298843002/60001

[commit-bot: I haz the power, 2014-05-22 18:16:35]

Change committed as 272239