Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4940)

Unified Diff: chrome/browser/media_galleries/fileapi/device_media_async_file_util.h

Issue 298843002: Media Galleries: Refactor DeviceMediaAsyncFileUtil. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media_galleries/fileapi/device_media_async_file_util.h
===================================================================
--- chrome/browser/media_galleries/fileapi/device_media_async_file_util.h (revision 271530)
+++ chrome/browser/media_galleries/fileapi/device_media_async_file_util.h (working copy)
@@ -12,20 +12,11 @@
#include "webkit/browser/fileapi/async_file_util.h"
#include "webkit/common/blob/shareable_file_reference.h"
-namespace base {
-class SequencedTaskRunner;
-class Time;
-}
-
namespace fileapi {
class FileSystemOperationContext;
class FileSystemURL;
}
-namespace net {
-class IOBuffer;
-}
-
namespace webkit_blob {
class FileStreamReader;
}
@@ -39,10 +30,8 @@
public:
virtual ~DeviceMediaAsyncFileUtil();
- // Returns an instance of DeviceMediaAsyncFileUtil. Returns NULL if
- // asynchronous operation is not supported. Callers own the returned
- // object.
- static DeviceMediaAsyncFileUtil* Create(
+ // Returns an instance of DeviceMediaAsyncFileUtil.
+ static scoped_ptr<DeviceMediaAsyncFileUtil> Create(
const base::FilePath& profile_path,
MediaFileValidationType validation_type);
@@ -137,17 +126,9 @@
// Called when GetFileInfo method call succeeds. |file_info| contains the
// file details of the requested url. |callback| is invoked to complete the
// GetFileInfo request.
- void OnDidGetFileInfo(
- const AsyncFileUtil::GetFileInfoCallback& callback,
- const base::File::Info& file_info);
+ void OnDidGetFileInfo(const GetFileInfoCallback& callback,
+ const base::File::Info& file_info);
- // Called when GetFileInfo method call failed to get the details of file
- // specified by the requested url. |callback| is invoked to notify the
- // caller about the file |error|.
- void OnGetFileInfoError(
- const AsyncFileUtil::GetFileInfoCallback& callback,
- base::File::Error error);
-
// Called when ReadDirectory method call succeeds. |callback| is invoked to
// complete the ReadDirectory request.
//
@@ -160,52 +141,12 @@
// in any two calls are disjoint), and |has_more| will be true, except for
// the last chunk.
void OnDidReadDirectory(
- const AsyncFileUtil::ReadDirectoryCallback& callback,
- const AsyncFileUtil::EntryList& file_list,
+ const ReadDirectoryCallback& callback,
+ const EntryList& file_list,
bool has_more);
- // Called when ReadDirectory method call failed to enumerate the directory
- // objects. |callback| is invoked to notify the caller about the |error|
- // that occured while reading the directory objects.
- void OnReadDirectoryError(
- const AsyncFileUtil::ReadDirectoryCallback& callback,
- base::File::Error error);
+ bool validate_media_files() const;
- // Called when the snapshot file specified by the |platform_path| is
- // successfully created. |file_info| contains the device media file details
- // for which the snapshot file is created.
- void OnDidCreateSnapshotFile(
- const AsyncFileUtil::CreateSnapshotFileCallback& callback,
- base::SequencedTaskRunner* media_task_runner,
- const base::File::Info& file_info,
- const base::FilePath& platform_path);
-
- // Called after OnDidCreateSnapshotFile finishes media check.
- // |callback| is invoked to complete the CreateSnapshotFile request.
- void OnDidCheckMedia(
- const AsyncFileUtil::CreateSnapshotFileCallback& callback,
- const base::File::Info& file_info,
- scoped_refptr<webkit_blob::ShareableFileReference> platform_file,
- base::File::Error error);
-
- // Called when CreateSnapshotFile method call fails. |callback| is invoked to
- // notify the caller about the |error|.
- void OnCreateSnapshotFileError(
- const AsyncFileUtil::CreateSnapshotFileCallback& callback,
- base::File::Error error);
-
- // Called when the snapshot file specified by the |snapshot_file_path| is
- // created to hold the contents of the url.path(). If the snapshot
- // file is successfully created, |snapshot_file_path| will be an non-empty
- // file path. In case of failure, |snapshot_file_path| will be an empty file
- // path. Forwards the CreateSnapshot request to the delegate to copy the
- // contents of url.path() to |snapshot_file_path|.
- void OnSnapshotFileCreatedRunTask(
- scoped_ptr<fileapi::FileSystemOperationContext> context,
- const AsyncFileUtil::CreateSnapshotFileCallback& callback,
- const fileapi::FileSystemURL& url,
- const base::FilePath& snapshot_file_path);
-
// Profile path.
const base::FilePath profile_path_;
« no previous file with comments | « no previous file | chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698