Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2988413002: [tq] Move to top-level package. (Closed)

Created:
3 years, 4 months ago by dnj
Modified:
3 years, 4 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[tq] Move to top-level package. Move the "tq" task dispatcher to a top-level package. This is useful outside of scheduler, and will be used in LogDog for task dispatching. BUG=chromium:751925 TEST=None R=vadimsh@chromium.org Review-Url: https://codereview.chromium.org/2988413002 Committed: https://github.com/luci/luci-go/commit/6553860f73d8b8e76215fa065c38021fbffe07de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -649 lines) Patch
A + appengine/tq/tq.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + appengine/tq/tq_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M scheduler/appengine/engine/cron/demo/main.go View 1 chunk +1 line, -1 line 0 comments Download
D scheduler/appengine/engine/tq/tq.go View 1 chunk +0 lines, -416 lines 0 comments Download
D scheduler/appengine/engine/tq/tq_test.go View 1 chunk +0 lines, -234 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
dnj
3 years, 4 months ago (2017-08-03 15:42:26 UTC) #1
Vadim Sh.
lgtm
3 years, 4 months ago (2017-08-03 17:30:13 UTC) #2
tandrii(chromium)
On 2017/08/03 17:30:13, Vadim Sh. wrote: > lgtm Yay, I suggested doing this during initial ...
3 years, 4 months ago (2017-08-03 17:32:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2988413002/1
3 years, 4 months ago (2017-08-03 17:44:55 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-08-03 17:48:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/6553860f73d8b8e76215fa065c38021fbffe07de

Powered by Google App Engine
This is Rietveld 408576698