Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2988403002: Add tests for change in https://codereview.chromium.org/2987403002/ (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
Reviewers:
Dmitry Stefantsov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M tools/gardening/lib/src/buildbot_structures.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gardening/test/compare_failures_test.dart View 2 chunks +38 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-03 10:08:23 UTC) #2
Dmitry Stefantsov
LGTM with one small comment from my inner dartanalyzer :) https://codereview.chromium.org/2988403002/diff/1/tools/gardening/test/compare_failures_test.dart File tools/gardening/test/compare_failures_test.dart (right): https://codereview.chromium.org/2988403002/diff/1/tools/gardening/test/compare_failures_test.dart#newcode49 ...
3 years, 4 months ago (2017-08-03 11:29:57 UTC) #3
Johnni Winther
3 years, 4 months ago (2017-08-03 12:01:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
771415a7c0d24f1fa3891230448ac978d2e6bbd2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698