Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tools/gardening/test/compare_failures_test.dart

Issue 2988403002: Add tests for change in https://codereview.chromium.org/2987403002/ (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gardening/lib/src/buildbot_structures.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gardening/test/compare_failures_test.dart
diff --git a/tools/gardening/test/compare_failures_test.dart b/tools/gardening/test/compare_failures_test.dart
index 63395c0d9c41de34058444025a7985413f5237c8..d13a13a8ff9802cb608f154a01f619f6a908ce55 100644
--- a/tools/gardening/test/compare_failures_test.dart
+++ b/tools/gardening/test/compare_failures_test.dart
@@ -23,6 +23,42 @@ main(List<String> args) async {
argParser.addFlag('force', abbr: 'f');
ArgResults argResults = argParser.parse(args);
processArgResults(argResults);
+
+ await runSingleTests(argResults);
+ await runGroupTests(argResults);
+}
+
+Future runGroupTests(ArgResults argResults) async {
+ BuildbotClient client = argResults['logdog']
+ ? new LogdogBuildbotClient()
+ : new HttpBuildbotClient();
+ await runGroupTest(client, 'vm-kernel');
+ client.close();
+}
+
+Future runGroupTest(BuildbotClient client, String testGroup) async {
+ print('Testing group compare-failures: $testGroup runCount=1');
+ Map<BuildUri, List<BuildResult>> buildResults =
+ await loadBuildResults(client, [testGroup], runCount: 1);
+ print('- checking results for ${buildResults.keys}');
+ buildResults.forEach((BuildUri buildUri, List<BuildResult> results) {
+ Expect.isTrue(buildUri.buildNumber < 0,
+ "Expected relative build number for $buildUri");
+ for (BuildResult result in results) {
+ Expect.isTrue(result.buildUri.buildNumber > 0,
+ "Expected absolute build number for build result ${result.buildUri}.");
Dmitry Stefantsov 2017/08/03 11:29:57 I guess this line is one symbol too long :)
+ for (TestFailure failure in result.failures) {
+ Expect.equals(
+ result.buildUri.buildNumber,
+ failure.uri.buildNumber,
+ "Expected absolute build number for test failure "
+ "'${failure.id}' from ${failure.uri}.");
+ }
+ }
+ });
+}
+
+Future runSingleTests(ArgResults argResults) async {
bool force = argResults['force'];
BuildbotClient client = argResults['logdog']
@@ -70,8 +106,10 @@ testSingleResults(
Future runSingleTest(BuildbotClient client, String testUri, int runCount,
Map<int, Map<String, String>> expectedResult) async {
+ print('Testing single compare-failures: $testUri runCount=$runCount');
Map<BuildUri, List<BuildResult>> buildResults =
await loadBuildResults(client, [testUri], runCount: runCount);
+ print('- checking results for ${buildResults.keys}');
if (LOG) {
printBuildResultsSummary(buildResults);
}
« no previous file with comments | « tools/gardening/lib/src/buildbot_structures.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698