Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1224)

Unified Diff: content/browser/web_contents/web_contents_view_aura_browsertest.cc

Issue 29883002: Attempt to re-land FocusManager removal from Aura. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Disable test with note. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views.cc ('k') | ui/aura/aura.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_view_aura_browsertest.cc
diff --git a/content/browser/web_contents/web_contents_view_aura_browsertest.cc b/content/browser/web_contents/web_contents_view_aura_browsertest.cc
index 7b060297c0ea7fa3fbb834ab5dca24c9000dc60c..0ccea2830a8420fbc07cd3f00c17581c7d9abeff 100644
--- a/content/browser/web_contents/web_contents_view_aura_browsertest.cc
+++ b/content/browser/web_contents/web_contents_view_aura_browsertest.cc
@@ -555,15 +555,15 @@ IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest,
EXPECT_EQ(NULL, screenshot_manager()->screenshot_taken_for());
}
-// Failing on win7_aura trybot (see crbug.com/260983).
-#if defined(OS_WIN)
-#define MAYBE_ContentWindowReparent \
- DISABLED_ContentWindowReparent
-#else
-#define MAYBE_ContentWindowReparent ContentWindowReparent
-#endif
+// TODO(sadrul): This test is disabled because it reparents in a way the
+// FocusController does not support. This code would crash in
+// a production build. It only passed prior to this revision
+// because testing used the old FocusManager which did some
+// different (osbolete) processing. TODO(sadrul) to figure out
+// how this test should work that mimics production code a bit
+// better.
IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest,
- MAYBE_ContentWindowReparent) {
+ DISABLED_ContentWindowReparent) {
ASSERT_NO_FATAL_FAILURE(
StartTestWithPage("files/overscroll_navigation.html"));
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views.cc ('k') | ui/aura/aura.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698