Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: content/browser/web_contents/web_contents_view_aura_browsertest.cc

Issue 29883002: Attempt to re-land FocusManager removal from Aura. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Disable test with note. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views.cc ('k') | ui/aura/aura.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_view_aura.h" 5 #include "content/browser/web_contents/web_contents_view_aura.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/run_loop.h" 8 #include "base/run_loop.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "base/test/test_timeouts.h" 10 #include "base/test/test_timeouts.h"
(...skipping 537 matching lines...) Expand 10 before | Expand all | Expand 10 after
548 // increased screenshot interval. 548 // increased screenshot interval.
549 NavigationController::LoadURLParams params(navigations[0].url); 549 NavigationController::LoadURLParams params(navigations[0].url);
550 params.transition_type = PageTransitionFromInt(navigations[0].transition); 550 params.transition_type = PageTransitionFromInt(navigations[0].transition);
551 web_contents->GetController().LoadURLWithParams(params); 551 web_contents->GetController().LoadURLWithParams(params);
552 WaitForLoadStop(web_contents); 552 WaitForLoadStop(web_contents);
553 screenshot_manager()->WaitUntilScreenshotIsReady(); 553 screenshot_manager()->WaitUntilScreenshotIsReady();
554 554
555 EXPECT_EQ(NULL, screenshot_manager()->screenshot_taken_for()); 555 EXPECT_EQ(NULL, screenshot_manager()->screenshot_taken_for());
556 } 556 }
557 557
558 // Failing on win7_aura trybot (see crbug.com/260983). 558 // TODO(sadrul): This test is disabled because it reparents in a way the
559 #if defined(OS_WIN) 559 // FocusController does not support. This code would crash in
560 #define MAYBE_ContentWindowReparent \ 560 // a production build. It only passed prior to this revision
561 DISABLED_ContentWindowReparent 561 // because testing used the old FocusManager which did some
562 #else 562 // different (osbolete) processing. TODO(sadrul) to figure out
563 #define MAYBE_ContentWindowReparent ContentWindowReparent 563 // how this test should work that mimics production code a bit
564 #endif 564 // better.
565 IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest, 565 IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest,
566 MAYBE_ContentWindowReparent) { 566 DISABLED_ContentWindowReparent) {
567 ASSERT_NO_FATAL_FAILURE( 567 ASSERT_NO_FATAL_FAILURE(
568 StartTestWithPage("files/overscroll_navigation.html")); 568 StartTestWithPage("files/overscroll_navigation.html"));
569 569
570 scoped_ptr<aura::Window> window(new aura::Window(NULL)); 570 scoped_ptr<aura::Window> window(new aura::Window(NULL));
571 window->Init(ui::LAYER_NOT_DRAWN); 571 window->Init(ui::LAYER_NOT_DRAWN);
572 572
573 WebContentsImpl* web_contents = 573 WebContentsImpl* web_contents =
574 static_cast<WebContentsImpl*>(shell()->web_contents()); 574 static_cast<WebContentsImpl*>(shell()->web_contents());
575 ExecuteSyncJSFunction(web_contents->GetRenderViewHost(), "navigate_next()"); 575 ExecuteSyncJSFunction(web_contents->GetRenderViewHost(), "navigate_next()");
576 EXPECT_EQ(1, GetCurrentIndex()); 576 EXPECT_EQ(1, GetCurrentIndex());
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
662 10); 662 10);
663 string16 actual_title = title_watcher.WaitAndGetTitle(); 663 string16 actual_title = title_watcher.WaitAndGetTitle();
664 EXPECT_EQ(expected_title, actual_title); 664 EXPECT_EQ(expected_title, actual_title);
665 665
666 EXPECT_EQ(2, GetCurrentIndex()); 666 EXPECT_EQ(2, GetCurrentIndex());
667 EXPECT_TRUE(controller.CanGoBack()); 667 EXPECT_TRUE(controller.CanGoBack());
668 EXPECT_FALSE(controller.CanGoForward()); 668 EXPECT_FALSE(controller.CanGoForward());
669 } 669 }
670 670
671 } // namespace content 671 } // namespace content
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views.cc ('k') | ui/aura/aura.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698