Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2988283002: tokenserver: Allow customizing list of OAuth scopes to use for CRL fetch. (Closed)

Created:
3 years, 4 months ago by Vadim Sh.
Modified:
3 years, 4 months ago
Reviewers:
Petr Hosek
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

tokenserver: Allow customizing list of OAuth scopes to use for CRL fetch. R=phosek@chromium.org BUG= Review-Url: https://codereview.chromium.org/2988283002 Committed: https://github.com/luci/luci-go/commit/47c0ca721d9ac27cdee5e5c8217b883c864c52f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1188 lines, -1165 lines) Patch
M tokenserver/api/admin/v1/config.proto View 1 chunk +1 line, -0 lines 0 comments Download
M tokenserver/api/admin/v1/config.pb.go View 3 chunks +52 lines, -42 lines 0 comments Download
M tokenserver/api/admin/v1/pb.discovery.go View 1 chunk +1125 lines, -1120 lines 0 comments Download
M tokenserver/appengine/impl/certconfig/rpc_fetch_crl.go View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Vadim Sh.
PTAL
3 years, 4 months ago (2017-08-02 00:39:58 UTC) #1
Petr Hosek
lgtm
3 years, 4 months ago (2017-08-02 00:47:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2988283002/1
3 years, 4 months ago (2017-08-02 00:48:27 UTC) #4
commit-bot: I haz the power
3 years, 4 months ago (2017-08-02 00:55:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/47c0ca721d9ac27cdee5e5c8217b883c864c52f2

Powered by Google App Engine
This is Rietveld 408576698