Fix mocked time in 'common/auth/localauth' tests.

Fix mocked time in 'common/auth/localauth' tests.

It incorrectly set local time as test time. TestRecentTimeLocal represents
different instances in time for different local timezones (but same local clock
readings).

The test later compares Unix representation of this time to a predefined value.
Unix time is always counted from UTC zone, so different moments in time have
different representations. The test hardcoded Unix representation of PST variant
of TestRecentTimeLocal, and so tests passed only in PST zone.

R=tandrii@chromium.org
BUG=747013
Review-Url: https://codereview.chromium.org/2988263002
Committed: https://github.com/luci/luci-go/commit/ad913aefc7240bcad0a7d52d31345b2e181b456a

[Vadim Sh., 2017-08-01 23:39:11]

The CQ bit was checked by vadimsh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-01 23:39:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-01 23:44:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-01 23:44:19]

Dry run: Try jobs failed on following builders:
  Luci-go Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/37b8fcdbc64d6210)
  Luci-go Win Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/37b8fcdc9e32ea10)

[Vadim Sh., 2017-08-01 23:49:16]

The CQ bit was checked by vadimsh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-01 23:49:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-01 23:54:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-01 23:54:18]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2017-08-02 09:37:04]

makes sense, LGTM. Thanks!

[tandrii(chromium), 2017-08-02 09:37:09]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2017-08-02 09:37:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-02 09:41:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1501666629293630,
"parent_rev": "fb82bfe733c86cb9d46ff4ebc0fec2d727abf8a8", "commit_rev":
"ad913aefc7240bcad0a7d52d31345b2e181b456a"}

[commit-bot: I haz the power, 2017-08-02 09:41:41]

Description was changed from

==========
Fix mocked time in 'common/auth/localauth' tests.

It incorrectly set local time as test time. TestRecentTimeLocal represents
different instances in time for different local timezones (but same local clock
readings).

The test later compares Unix representation of this time to a predefined value.
Unix time is always counted from UTC zone, so different moments in time have
different representations. The test hardcoded Unix representation of PST variant
of TestRecentTimeLocal, and so tests passed only in PST zone.

R=tandrii@chromium.org
BUG=747013
==========

to

==========
Fix mocked time in 'common/auth/localauth' tests.

It incorrectly set local time as test time. TestRecentTimeLocal represents
different instances in time for different local timezones (but same local clock
readings).

The test later compares Unix representation of this time to a predefined value.
Unix time is always counted from UTC zone, so different moments in time have
different representations. The test hardcoded Unix representation of PST variant
of TestRecentTimeLocal, and so tests passed only in PST zone.

R=tandrii@chromium.org
BUG=747013

Review-Url: https://codereview.chromium.org/2988263002
Committed:
https://github.com/luci/luci-go/commit/ad913aefc7240bcad0a7d52d31345b2e181b456a
==========

[commit-bot: I haz the power, 2017-08-02 09:41:43]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/ad913aefc7240bcad0a7d52d31345b2e181b456a