Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2988223002: config_service: make validation errors more distinguishable (Closed)

Created:
3 years, 4 months ago by ayanaadylova
Modified:
3 years, 4 months ago
Reviewers:
Sergey Berezin, nodir
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

config_service: make validation errors more distinguishable BUG=749999 Review-Url: https://codereview.chromium.org/2988223002 Committed: https://github.com/luci/luci-py/commit/e5c03a06ae1e8585f4944d2b57ab156ed5b5f071

Patch Set 1 #

Patch Set 2 : Nit: change icon for force refresh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M appengine/config_service/ui/src/config-ui/config-set.html View 1 2 chunks +4 lines, -2 lines 0 comments Download
M appengine/config_service/ui/src/config-ui/config-set-card.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
ayanaadylova
PTAL Screenshot: https://screenshot.googleplex.com/sN28OHpuiCN
3 years, 4 months ago (2017-07-31 23:07:15 UTC) #2
Sergey Berezin
lgtm
3 years, 4 months ago (2017-08-01 00:34:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2988223002/20001
3 years, 4 months ago (2017-08-01 21:22:03 UTC) #6
commit-bot: I haz the power
3 years, 4 months ago (2017-08-01 21:24:13 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/e5c03a06ae1e8585f4944d2b57ab156ed5b5f071

Powered by Google App Engine
This is Rietveld 408576698