Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2988153002: Add components for handling of exceptions (Closed)

Created:
3 years, 4 months ago by zhivkag
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rename 'ExceptionState' to 'Handlers' #

Patch Set 3 : Merge #

Total comments: 1

Patch Set 4 : Rename Handlers to ExceptionComponents #

Patch Set 5 : Megre #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -112 lines) Patch
M pkg/kernel/lib/interpreter/interpreter.dart View 1 2 3 38 chunks +232 lines, -112 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
zhivkag
3 years, 4 months ago (2017-08-03 07:07:09 UTC) #2
Dmitry Stefantsov
That's a big step to the interpreter which LGTM! Please, find one traditional naming-related comment ...
3 years, 4 months ago (2017-08-03 08:45:17 UTC) #3
zhivkag
3 years, 4 months ago (2017-08-03 09:35:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
dde7ce2ab060b7748f2bc90968d81640ada56ac9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698