Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 2988063002: Use dart2js_plaform.dill from the sdk. (Closed)
Patch Set: add comment about why --host-checked and --use-sdk is not supported Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language_2/language_2.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 009fdfe62bef8ddce681a7d92ccbe1571e5485cb..e665d85670495a70f14242166e5f46eb9f072395 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -283,6 +283,13 @@ class Dart2xCompilerConfiguration extends CompilerConfiguration {
var suffix = executableScriptSuffix;
if (_isHostChecked) {
+ if (_useSdk) {
+ // Note: when [_useSdk] is true, dart2js is run from a snapshot that was
+ // built without checked mode. The VM cannot make such snapshot run in
+ // checked mode later. These two flags could be used together if we also
+ // build an sdk with checked snapshots.
+ throw "--host-checked and --use-sdk cannot be used together";
+ }
// The script dart2js_developer is not included in the
// shipped SDK, that is the script is not installed in
// "$buildDir/dart-sdk/bin/"
« no previous file with comments | « tests/language_2/language_2.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698