Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: tools/testing/dart/compiler_configuration.dart

Issue 2988063002: Use dart2js_plaform.dill from the sdk. (Closed)
Patch Set: add comment about why --host-checked and --use-sdk is not supported Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tests/language_2/language_2.status ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:io'; 5 import 'dart:io';
6 6
7 import 'command.dart'; 7 import 'command.dart';
8 import 'configuration.dart'; 8 import 'configuration.dart';
9 import 'path.dart'; 9 import 'path.dart';
10 import 'runtime_configuration.dart'; 10 import 'runtime_configuration.dart';
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 static Map<String, List<Uri>> _bootstrapDependenciesCache = {}; 276 static Map<String, List<Uri>> _bootstrapDependenciesCache = {};
277 277
278 Dart2xCompilerConfiguration(this.moniker, Configuration configuration) 278 Dart2xCompilerConfiguration(this.moniker, Configuration configuration)
279 : super._subclass(configuration); 279 : super._subclass(configuration);
280 280
281 String computeCompilerPath() { 281 String computeCompilerPath() {
282 var prefix = 'sdk/bin'; 282 var prefix = 'sdk/bin';
283 var suffix = executableScriptSuffix; 283 var suffix = executableScriptSuffix;
284 284
285 if (_isHostChecked) { 285 if (_isHostChecked) {
286 if (_useSdk) {
287 // Note: when [_useSdk] is true, dart2js is run from a snapshot that was
288 // built without checked mode. The VM cannot make such snapshot run in
289 // checked mode later. These two flags could be used together if we also
290 // build an sdk with checked snapshots.
291 throw "--host-checked and --use-sdk cannot be used together";
292 }
286 // The script dart2js_developer is not included in the 293 // The script dart2js_developer is not included in the
287 // shipped SDK, that is the script is not installed in 294 // shipped SDK, that is the script is not installed in
288 // "$buildDir/dart-sdk/bin/" 295 // "$buildDir/dart-sdk/bin/"
289 return '$prefix/dart2js_developer$suffix'; 296 return '$prefix/dart2js_developer$suffix';
290 } 297 }
291 298
292 if (_useSdk) { 299 if (_useSdk) {
293 prefix = '${_configuration.buildDirectory}/dart-sdk/bin'; 300 prefix = '${_configuration.buildDirectory}/dart-sdk/bin';
294 } 301 }
295 return '$prefix/dart2js$suffix'; 302 return '$prefix/dart2js$suffix';
(...skipping 445 matching lines...) Expand 10 before | Expand all | Expand 10 after
741 List<String> computeRuntimeArguments( 748 List<String> computeRuntimeArguments(
742 RuntimeConfiguration runtimeConfiguration, 749 RuntimeConfiguration runtimeConfiguration,
743 TestInformation info, 750 TestInformation info,
744 List<String> vmOptions, 751 List<String> vmOptions,
745 List<String> sharedOptions, 752 List<String> sharedOptions,
746 List<String> originalArguments, 753 List<String> originalArguments,
747 CommandArtifact artifact) { 754 CommandArtifact artifact) {
748 return <String>[]; 755 return <String>[];
749 } 756 }
750 } 757 }
OLDNEW
« no previous file with comments | « tests/language_2/language_2.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698