Use dart2js_plaform.dill from the sdk.

Use dart2js_plaform.dill from the sdk.

This will enable --use-kernel tests in the dart2js bots.

After this change, running our tests will change a little bit, either of these
would work:

Option A: --use-sdk (host-checked not allowed)

python tools/test.py -m release \
   -c dart2js -r d8 --dart2js-batch --report \
   --dart2js-with-kernel --use-sdk \
   language corelib library_2 corelib_2 \
   dart2js_native dart2js_extra

Option B: pass --library-root, --host-check works here.
python tools/test.py -m release \
   -c dart2js -r d8 --dart2js-batch --report \
   --dart2js-with-kernel --host-checked \
   --dart2js_options="--library-root=out/ReleaseX64/dart-sdk/" \
   language corelib library_2 corelib_2 \
   dart2js_native dart2js_extra

In the future, when fasta supports compiling sdk with @patch files, we will
be able to remove the --library-root option and simply compile the SDK from
sources at that point.

BUG=
R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/b1065335cdb41ddf12f2dd3d3723bfe20f8e5c14

[Siggi Cherem (dart-lang), 2017-07-28 00:44:34]

Description was changed from

==========
Use dart2js_plaform.dill from the build sdk.

This will enable --use-kernel tests in the dart2js bots.

After this change, running our tests will change a little bit, either of these
would work:

Option A: --use-sdk (host-checked not allowed)

python tools/test.py -m release \
   -c dart2js -r d8 --dart2js-batch --report \
   --dart2js-with-kernel --use-sdk \
   language corelib library_2 corelib_2 \
   dart2js_native dart2js_extra

Option B: pass --library-root, --host-check works here.
python tools/test.py -m release \
   -c dart2js -r d8 --dart2js-batch --report \
   --dart2js-with-kernel --host-checked \
   --dart2js_options="--library-root=out/ReleaseX64/dart-sdk/" \
   language corelib library_2 corelib_2 \
   dart2js_native dart2js_extra

In the future, when fasta supports compiling sdk with @patch files, we will
be able to remove the --library-root option and simply compile the SDK from
sources at that point.

BUG=
==========

to

==========
Use dart2js_plaform.dill from the sdk.

This will enable --use-kernel tests in the dart2js bots.

After this change, running our tests will change a little bit, either of these
would work:

Option A: --use-sdk (host-checked not allowed)

python tools/test.py -m release \
   -c dart2js -r d8 --dart2js-batch --report \
   --dart2js-with-kernel --use-sdk \
   language corelib library_2 corelib_2 \
   dart2js_native dart2js_extra

Option B: pass --library-root, --host-check works here.
python tools/test.py -m release \
   -c dart2js -r d8 --dart2js-batch --report \
   --dart2js-with-kernel --host-checked \
   --dart2js_options="--library-root=out/ReleaseX64/dart-sdk/" \
   language corelib library_2 corelib_2 \
   dart2js_native dart2js_extra

In the future, when fasta supports compiling sdk with @patch files, we will
be able to remove the --library-root option and simply compile the SDK from
sources at that point.

BUG=
==========

[Siggi Cherem (dart-lang), 2017-07-28 00:46:08]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2017-07-28 00:54:10]

Patchset #1 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2017-07-28 00:56:00]

sigmund@google.com changed reviewers:
+ efortuna@google.com, johnniwinther@google.com

[Johnni Winther, 2017-07-28 15:54:19]

lgtm

https://codereview.chromium.org/2988063002/diff/40001/tools/testing/dart/comp...
File tools/testing/dart/compiler_configuration.dart (right):

https://codereview.chromium.org/2988063002/diff/40001/tools/testing/dart/comp...
tools/testing/dart/compiler_configuration.dart:287: throw "--host-checked and
--use-sdk cannot be used together";
Why not? Is it short term?

[Siggi Cherem (dart-lang), 2017-07-28 16:45:05]

https://codereview.chromium.org/2988063002/diff/40001/tools/testing/dart/comp...
File tools/testing/dart/compiler_configuration.dart (right):

https://codereview.chromium.org/2988063002/diff/40001/tools/testing/dart/comp...
tools/testing/dart/compiler_configuration.dart:287: throw "--host-checked and
--use-sdk cannot be used together";
On 2017/07/28 15:54:19, Johnni Winther wrote:
> Why not? Is it short term?

Added a note in the code.

I actually tried implementing this by defining the DART_VM_OPTIONS environment
and passing the flag, but turns out that --use-sdk runs dart2js from a snapshot,
and sdk snapshots are built without checked mode. If you try to run the
non-checked snapshot and pass `--checked` to the vm, the vm complains.

I believe this is not going to be supported unless we start building checked
snapshots in the sdk in the future.

[Siggi Cherem (dart-lang), 2017-07-28 17:07:14]

Description was changed from

==========
Use dart2js_plaform.dill from the sdk.

This will enable --use-kernel tests in the dart2js bots.

After this change, running our tests will change a little bit, either of these
would work:

Option A: --use-sdk (host-checked not allowed)

python tools/test.py -m release \
   -c dart2js -r d8 --dart2js-batch --report \
   --dart2js-with-kernel --use-sdk \
   language corelib library_2 corelib_2 \
   dart2js_native dart2js_extra

Option B: pass --library-root, --host-check works here.
python tools/test.py -m release \
   -c dart2js -r d8 --dart2js-batch --report \
   --dart2js-with-kernel --host-checked \
   --dart2js_options="--library-root=out/ReleaseX64/dart-sdk/" \
   language corelib library_2 corelib_2 \
   dart2js_native dart2js_extra

In the future, when fasta supports compiling sdk with @patch files, we will
be able to remove the --library-root option and simply compile the SDK from
sources at that point.

BUG=
==========

to

==========
Use dart2js_plaform.dill from the sdk.

This will enable --use-kernel tests in the dart2js bots.

After this change, running our tests will change a little bit, either of these
would work:

Option A: --use-sdk (host-checked not allowed)

python tools/test.py -m release \
   -c dart2js -r d8 --dart2js-batch --report \
   --dart2js-with-kernel --use-sdk \
   language corelib library_2 corelib_2 \
   dart2js_native dart2js_extra

Option B: pass --library-root, --host-check works here.
python tools/test.py -m release \
   -c dart2js -r d8 --dart2js-batch --report \
   --dart2js-with-kernel --host-checked \
   --dart2js_options="--library-root=out/ReleaseX64/dart-sdk/" \
   language corelib library_2 corelib_2 \
   dart2js_native dart2js_extra

In the future, when fasta supports compiling sdk with @patch files, we will
be able to remove the --library-root option and simply compile the SDK from
sources at that point.

BUG=
R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b1065335cdb41ddf12f2dd3d3723bfe20f8e5c14
==========

[Siggi Cherem (dart-lang), 2017-07-28 17:07:15]

Committed patchset #2 (id:60001) manually as
b1065335cdb41ddf12f2dd3d3723bfe20f8e5c14 (presubmit successful).