Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2988053002: config_service: change pop-up message for force refresh button. (Closed)

Created:
3 years, 4 months ago by ayanaadylova
Modified:
3 years, 4 months ago
Reviewers:
Sergey Berezin, hinoka
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

config_service: change pop-up message for force refresh button. BUG=749537 Review-Url: https://codereview.chromium.org/2988053002 Committed: https://github.com/luci/luci-py/commit/fb37d8ec0b57e2a582f32aae3155b11b7ce47eff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M appengine/config_service/ui/src/config-ui/config-set.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
ayanaadylova
PTAL
3 years, 4 months ago (2017-07-27 18:19:57 UTC) #2
Sergey Berezin
LGTM + nits on CL description. Thanks! nit: s/refrech/refresh/ (typo in the title) nit: the ...
3 years, 4 months ago (2017-07-27 20:45:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2988053002/1
3 years, 4 months ago (2017-07-27 22:10:40 UTC) #7
commit-bot: I haz the power
3 years, 4 months ago (2017-07-27 22:13:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/fb37d8ec0b57e2a582f32aae3155b11b7ce47eff

Powered by Google App Engine
This is Rietveld 408576698