Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2987893002:
[cipd] Enable specific log level. (Closed)
Description[cipd] Enable specific log level.
Add a flag to CIPD client subcommand invocations that explicitly sets
the logging level. This is more precise than "-verbose", and can be used
to suppress INFO-level logs in situations where users don't want to see
them.
BUG=chromium:748651
TEST=local
R=dpranke@chromium.org, vadimsh@chromium.org
Review-Url: https://codereview.chromium.org/2987893002
Committed: https://github.com/luci/luci-go/commit/8ccb74d02ea1ac77c1bff3a6230d7e8dd2280817
Patch Set 1 #
Total comments: 2
Patch Set 2 : [cipd] Enable specific log level. #Patch Set 3 : [cipd] Enable specific log level. #Messages
Total messages: 21 (12 generated)
The CQ bit was checked by dnj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2987893002/diff/1/cipd/client/cli/main.go File cipd/client/cli/main.go (right): https://codereview.chromium.org/2987893002/diff/1/cipd/client/cli/main.go#new... cipd/client/cli/main.go:113: c.Flags.BoolVar(&c.verbose, "verbose", false, "Enable debug-level logging.") I think we can kill this flag. No scripts is using it AFAIK. At very least mark is as "[deprecated]". Having two flags for same thing is weird.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2987893002/diff/1/cipd/client/cli/main.go File cipd/client/cli/main.go (right): https://codereview.chromium.org/2987893002/diff/1/cipd/client/cli/main.go#new... cipd/client/cli/main.go:113: c.Flags.BoolVar(&c.verbose, "verbose", false, "Enable debug-level logging.") On 2017/07/26 03:47:44, Vadim Sh. wrote: > I think we can kill this flag. No scripts is using it AFAIK. > > At very least mark is as "[deprecated]". Having two flags for same thing is > weird. I suppose since we pin CIPD, this is a relatively safe thing to do. Done.
The CQ bit was checked by dnj@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
On 2017/07/26 17:22:40, Vadim Sh. wrote: > lgtm Welp, I was wrong: https://cs.chromium.org/chromium/infra/luci/client/cipd.py?type=cs&q=%27cipd%...
On 2017/07/26 17:23:28, Vadim Sh. wrote: > On 2017/07/26 17:22:40, Vadim Sh. wrote: > > lgtm > > Welp, I was wrong: > https://cs.chromium.org/chromium/infra/luci/client/cipd.py?type=cs&q=%27cipd%... OK good catch. I'll leave the flag in for now and mark that it is deprecated, and we can remove it at some point after we've rolled everything that we know uses it.
The CQ bit was checked by dnj@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org Link to the patchset: https://codereview.chromium.org/2987893002/#ps40001 (title: "[cipd] Enable specific log level.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1501098161114320,
"parent_rev": "f4e9bd5ac290f75fb9c40babee6781d741ce4f3c", "commit_rev":
"8ccb74d02ea1ac77c1bff3a6230d7e8dd2280817"}
Message was sent while issue was closed.
Description was changed from ========== [cipd] Enable specific log level. Add a flag to CIPD client subcommand invocations that explicitly sets the logging level. This is more precise than "-verbose", and can be used to suppress INFO-level logs in situations where users don't want to see them. BUG=chromium:748651 TEST=local R=dpranke@chromium.org, vadimsh@chromium.org ========== to ========== [cipd] Enable specific log level. Add a flag to CIPD client subcommand invocations that explicitly sets the logging level. This is more precise than "-verbose", and can be used to suppress INFO-level logs in situations where users don't want to see them. BUG=chromium:748651 TEST=local R=dpranke@chromium.org, vadimsh@chromium.org Review-Url: https://codereview.chromium.org/2987893002 Committed: https://github.com/luci/luci-go/commit/8ccb74d02ea1ac77c1bff3a6230d7e8dd2280817 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://github.com/luci/luci-go/commit/8ccb74d02ea1ac77c1bff3a6230d7e8dd2280817
Message was sent while issue was closed.
I'm no go reviewer, but the idea seems fine :). |
