Additional fixes for invalid overrides in dart2js

Additional fixes for invalid overrides in dart2js

Together with Jen's fix for checking mixin, these are the remaining cases in
dart2js that we need to silence strong mode errors.

For modelz - the plan is to eventually delete this code, so ignoring makes sense
here. For the namer, Stephen believes we should get rid of the special
subclasses, for now I'm just supressing the error.

R=johhniwinther@google.com, sra@google.com
CC=jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/86e18de920322e0c812c325cf3c00bfe33e6363d

[Siggi Cherem (dart-lang), 2017-07-24 22:41:32]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2017-07-24 22:57:14]

Patchset #1 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2017-07-24 22:59:13]

Patchset #1 (id:40001) has been deleted

[Siggi Cherem (dart-lang), 2017-07-24 23:02:24]

https://codereview.chromium.org/2987783002/diff/60001/pkg/compiler/lib/src/el...
File pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/2987783002/diff/60001/pkg/compiler/lib/src/el...
pkg/compiler/lib/src/elements/modelx.dart:3576: this.patch = patch;
the alternative is to add `as E` here. I might want to do that separately to
measure the impact on golem. This code is anyways going to be deleted in the
long run...

[Siggi Cherem (dart-lang), 2017-07-24 23:17:45]

Description was changed from

==========
Additional fixes for invalid overrides in dart2js

Together with Jen's fix for checking mixin, these are the remaining cases in
dart2js that we need to silence strong mode errors.

For modelz - the plan is to eventually delete this code, so ignoring makes sense
here. For the namer, Stephen believes we should get rid of the special
subclasses, for now I'm just supressing the error.

R=sra1@google.com,johhniwinther@google.com
CC=jmesserly@google.com
==========

to

==========
Additional fixes for invalid overrides in dart2js

Together with Jen's fix for checking mixin, these are the remaining cases in
dart2js that we need to silence strong mode errors.

For modelz - the plan is to eventually delete this code, so ignoring makes sense
here. For the namer, Stephen believes we should get rid of the special
subclasses, for now I'm just supressing the error.

R=sra1@google.com,johhniwinther@google.com
CC=jmesserly@google.com
==========

[Siggi Cherem (dart-lang), 2017-07-24 23:17:45]

sigmund@google.com changed reviewers:
+ sra@google.com
- sra1@google.com

[Siggi Cherem (dart-lang), 2017-07-24 23:18:26]

Description was changed from

==========
Additional fixes for invalid overrides in dart2js

Together with Jen's fix for checking mixin, these are the remaining cases in
dart2js that we need to silence strong mode errors.

For modelz - the plan is to eventually delete this code, so ignoring makes sense
here. For the namer, Stephen believes we should get rid of the special
subclasses, for now I'm just supressing the error.

R=sra1@google.com,johhniwinther@google.com
CC=jmesserly@google.com
==========

to

==========
Additional fixes for invalid overrides in dart2js

Together with Jen's fix for checking mixin, these are the remaining cases in
dart2js that we need to silence strong mode errors.

For modelz - the plan is to eventually delete this code, so ignoring makes sense
here. For the namer, Stephen believes we should get rid of the special
subclasses, for now I'm just supressing the error.

R=sra@google.com,johhniwinther@google.com
CC=jmesserly@google.com
==========

[sra1, 2017-07-24 23:20:08]

lgtm

[Siggi Cherem (dart-lang), 2017-07-24 23:25:33]

Description was changed from

==========
Additional fixes for invalid overrides in dart2js

Together with Jen's fix for checking mixin, these are the remaining cases in
dart2js that we need to silence strong mode errors.

For modelz - the plan is to eventually delete this code, so ignoring makes sense
here. For the namer, Stephen believes we should get rid of the special
subclasses, for now I'm just supressing the error.

R=sra@google.com,johhniwinther@google.com
CC=jmesserly@google.com
==========

to

==========
Additional fixes for invalid overrides in dart2js

Together with Jen's fix for checking mixin, these are the remaining cases in
dart2js that we need to silence strong mode errors.

For modelz - the plan is to eventually delete this code, so ignoring makes sense
here. For the namer, Stephen believes we should get rid of the special
subclasses, for now I'm just supressing the error.

R=johhniwinther@google.com, sra@google.com
CC=jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/86e18de920322e0c812c325cf3c00bfe33e6363d
==========

[Siggi Cherem (dart-lang), 2017-07-24 23:25:35]

Committed patchset #1 (id:60001) manually as
86e18de920322e0c812c325cf3c00bfe33e6363d (presubmit successful).

[karlklose, 2017-07-26 13:39:26]

On 2017/07/24 23:25:35, Siggi Cherem (dart-lang) wrote:
> Committed patchset #1 (id:60001) manually as
> 86e18de920322e0c812c325cf3c00bfe33e6363d (presubmit successful).

This change broke dart2js/analyze_unused_dart2js_test

[Siggi Cherem (dart-lang), 2017-07-26 19:51:12]

On 2017/07/26 13:39:26, karlklose wrote:
> On 2017/07/24 23:25:35, Siggi Cherem (dart-lang) wrote:
> > Committed patchset #1 (id:60001) manually as
> > 86e18de920322e0c812c325cf3c00bfe33e6363d (presubmit successful).
> 
> This change broke dart2js/analyze_unused_dart2js_test

bummer - thanks for pointing it out. There were other failures shadowing this
one on the bots when I first introduced it.

The "ignore" comment doesn't work for that test because it is using dart2js to
generate the warnings and not dartanalyzer. Emily is about to send a fix, we
should later consider deleting this test suite.