Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: pkg/compiler/lib/src/js_backend/namer_names.dart

Issue 2987783002: Additional fixes for invalid overrides in dart2js (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/namer_names.dart
diff --git a/pkg/compiler/lib/src/js_backend/namer_names.dart b/pkg/compiler/lib/src/js_backend/namer_names.dart
index 981e3a87e35c82a00a793dd8d684ba691e34d1e3..9f351e395367a98719cfc66b3823435d431a34b2 100644
--- a/pkg/compiler/lib/src/js_backend/namer_names.dart
+++ b/pkg/compiler/lib/src/js_backend/namer_names.dart
@@ -4,6 +4,7 @@
part of js_backend.namer;
+// ignore: STRONG_MODE_INVALID_METHOD_OVERRIDE_FROM_BASE
abstract class _NamerName extends jsAst.Name {
int get _kind;
_NamerName get _target => this;
@@ -18,6 +19,7 @@ abstract class _NamerName extends jsAst.Name {
enum _NamerNameKinds { StringBacked, Getter, Setter, Async, Compound, Token }
+// ignore: STRONG_MODE_INVALID_METHOD_OVERRIDE_FROM_BASE
class StringBackedName extends _NamerName {
final String name;
int get _kind => _NamerNameKinds.StringBacked.index;
@@ -41,6 +43,7 @@ class StringBackedName extends _NamerName {
}
}
+// ignore: STRONG_MODE_INVALID_METHOD_OVERRIDE_FROM_BASE
abstract class _PrefixedName extends _NamerName implements jsAst.AstContainer {
final jsAst.Name prefix;
final jsAst.Name base;
@@ -78,18 +81,21 @@ abstract class _PrefixedName extends _NamerName implements jsAst.AstContainer {
}
}
+// ignore: STRONG_MODE_INVALID_METHOD_OVERRIDE_FROM_BASE
class GetterName extends _PrefixedName {
int get _kind => _NamerNameKinds.Getter.index;
GetterName(jsAst.Name prefix, jsAst.Name base) : super(prefix, base);
}
+// ignore: STRONG_MODE_INVALID_METHOD_OVERRIDE_FROM_BASE
class SetterName extends _PrefixedName {
int get _kind => _NamerNameKinds.Setter.index;
SetterName(jsAst.Name prefix, jsAst.Name base) : super(prefix, base);
}
+// ignore: STRONG_MODE_INVALID_METHOD_OVERRIDE_FROM_BASE
class _AsyncName extends _PrefixedName {
int get _kind => _NamerNameKinds.Async.index;
@@ -99,6 +105,7 @@ class _AsyncName extends _PrefixedName {
bool get allowRename => true;
}
+// ignore: STRONG_MODE_INVALID_METHOD_OVERRIDE_FROM_BASE
class CompoundName extends _NamerName implements jsAst.AstContainer {
final List<_NamerName> _parts;
int get _kind => _NamerNameKinds.Compound.index;
@@ -154,6 +161,7 @@ class CompoundName extends _NamerName implements jsAst.AstContainer {
}
}
+// ignore: STRONG_MODE_INVALID_METHOD_OVERRIDE_FROM_BASE
class TokenName extends _NamerName implements jsAst.ReferenceCountedAstNode {
int get _kind => _NamerNameKinds.Token.index;
String _name;
@@ -199,6 +207,7 @@ class TokenName extends _NamerName implements jsAst.ReferenceCountedAstNode {
}
}
+// ignore: STRONG_MODE_INVALID_METHOD_OVERRIDE_FROM_BASE
class _NameReference extends _NamerName implements jsAst.AstContainer {
_NamerName _target;

Powered by Google App Engine
This is Rietveld 408576698