Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 298753004: Fix an early return and the error status in glLoseContextCHROMIUM impl (Closed)

Created:
6 years, 7 months ago by Kimmo Kinnunen
Modified:
6 years, 7 months ago
Reviewers:
vmiura, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cmd-buffer-missing-early-returns
Visibility:
Public.

Description

Fix an early return and the error status in glLoseContextCHROMIUM impl The implementation of glLoseContextCHROMIUM did not return early in gl error conditions of invalid enums passed as arguments. Add the early returns and tests for the invalid enums. Upon successful glLoseContextCHROMIUM, the subsequent calls such as glGetError would also fail, because the implementation would set the decoder error variable as well as return the error value. Fix this by just setting the decoder error variable. Add a test for this (LoseContextCHROMIUMValidArgs) BUG=373159 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -26 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 chunk +3 lines, -2 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 4 chunks +11 lines, -18 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 chunk +18 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Kimmo Kinnunen
the lose context part of the missing return values bug.
6 years, 7 months ago (2014-05-21 07:29:45 UTC) #1
piman
lgtm
6 years, 7 months ago (2014-05-21 20:57:33 UTC) #2
vmiura
lgtm
6 years, 7 months ago (2014-05-22 05:02:36 UTC) #3
Kimmo Kinnunen
The CQ bit was checked by kkinnunen@nvidia.com
6 years, 7 months ago (2014-05-23 08:22:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkinnunen@nvidia.com/298753004/1
6 years, 7 months ago (2014-05-23 08:23:47 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 13:05:05 UTC) #6
Message was sent while issue was closed.
Change committed as 272507

Powered by Google App Engine
This is Rietveld 408576698