gpu/command_buffer/build_gles2_cmd_buffer.py - Issue 298753004: Fix an early return and the error status in glLoseContextCHROMIUM impl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/build_gles2_cmd_buffer.py

Issue 298753004: Fix an early return and the error status in glLoseContextCHROMIUM impl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cmd-buffer-missing-early-returns

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/build_gles2_cmd_buffer.py

diff --git a/gpu/command_buffer/build_gles2_cmd_buffer.py b/gpu/command_buffer/build_gles2_cmd_buffer.py

index 470ff299c2515234dc08f8f2acc21156b2812dfe..d918b73e75fe487ae7f9218507c2a6226dfaf03b 100755

--- a/gpu/command_buffer/build_gles2_cmd_buffer.py

+++ b/gpu/command_buffer/build_gles2_cmd_buffer.py

@@ -2540,8 +2540,8 @@ _FUNCTION_INFO = {

'extension_flag': 'ext_discard_framebuffer',

'LoseContextCHROMIUM': {

- 'type': 'Manual',

- 'impl_func': True,

+ 'decoder_func': 'DoLoseContextCHROMIUM',

+ 'unit_test': False,

'extension': True,

'chromium': True,

« no previous file with comments | « no previous file | gpu/command_buffer/client/gles2_implementation_impl_autogen.h » ('j') | no next file with comments »