Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2987513002: [datastore] improve docs around auto-generated *Keys on Put. (Closed)

Created:
3 years, 5 months ago by iannucci
Modified:
3 years, 5 months ago
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M service/datastore/interface.go View 2 chunks +8 lines, -3 lines 0 comments Download
M service/datastore/key.go View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
iannucci
3 years, 5 months ago (2017-07-20 02:06:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2987513002/1
3 years, 5 months ago (2017-07-20 02:06:15 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-07-20 02:06:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2987513002/1
3 years, 5 months ago (2017-07-20 02:09:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/gae/commit/52a3b010d9f5696bfb2c9be999402bb8b27af38e
3 years, 5 months ago (2017-07-20 02:14:00 UTC) #12
seanmccullough1
3 years, 5 months ago (2017-07-20 15:30:24 UTC) #14
Message was sent while issue was closed.
lgtm

Thanks!

Powered by Google App Engine
This is Rietveld 408576698