Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2987453002: config_service: fix testing (Closed)

Created:
3 years, 5 months ago by ayanaadylova
Modified:
3 years, 5 months ago
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

config_service: fix testing Fixed all issues with tests. All tests now pass in both Chrome and Firefox and iron-ajax now calls on-response function automatically. BUG=740768 Review-Url: https://codereview.chromium.org/2987453002 Committed: https://github.com/luci/luci-py/commit/71a750423b8a2f4042d8fe3f7135a3152248f308

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -112 lines) Patch
M appengine/config_service/ui/src/config-ui/config-set.html View 2 chunks +3 lines, -0 lines 0 comments Download
M appengine/config_service/ui/src/config-ui/front-page.html View 1 chunk +1 line, -0 lines 0 comments Download
M appengine/config_service/ui/test/config-ui/config-set_test.html View 6 chunks +45 lines, -55 lines 0 comments Download
M appengine/config_service/ui/test/config-ui/front-page_test.html View 2 chunks +54 lines, -57 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ayanaadylova
PTAL
3 years, 5 months ago (2017-07-19 20:48:43 UTC) #2
Ryan Tseng
lgtm !
3 years, 5 months ago (2017-07-19 22:35:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2987453002/1
3 years, 5 months ago (2017-07-19 22:39:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/luci-py/commit/71a750423b8a2f4042d8fe3f7135a3152248f308
3 years, 5 months ago (2017-07-19 22:42:18 UTC) #9
Sergey Berezin
3 years, 5 months ago (2017-07-19 23:16:19 UTC) #10
Message was sent while issue was closed.
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698